Coder Social home page Coder Social logo

Remove lodash dep about victory HOT 6 CLOSED

formidablelabs avatar formidablelabs commented on May 17, 2024
Remove lodash dep

from victory.

Comments (6)

knowbody avatar knowbody commented on May 17, 2024

these might be good resources for this issue:

Have in mind that if we use Object.assign we need to add babel-polyfill to the builder config (if it's not there already).

from victory.

boygirl avatar boygirl commented on May 17, 2024

@ryan-roemer is philosophically opposed to shipping polyfills last time I checked.

from victory.

ryan-roemer avatar ryan-roemer commented on May 17, 2024

Libraries should never mutate your application merely from inclusion. So don't implement polyfills.

But requiring them is perfectly fine as long as it's well-documented. And maybe it makes sense throw an exception if they're not present in development mode.

from victory.

ryan-roemer avatar ryan-roemer commented on May 17, 2024

And in your application server you absolutely should be doing polyfills. Just a single lib or component should respect and not change the environment in which it is used.

from victory.

ryan-roemer avatar ryan-roemer commented on May 17, 2024

Last thought - non mutating ponyfills (not polyfills) are ok too, but be careful with interaction with real polyfills in apps

from victory.

knowbody avatar knowbody commented on May 17, 2024

I've just seen this: https://github.com/cht8687/You-Dont-Need-Lodash-Underscore
might be useful, so leaving this here.

from victory.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.