Coder Social home page Coder Social logo

Comments (8)

gzurbach avatar gzurbach commented on June 2, 2024 1

Sure thing: https://codesandbox.io/s/javascript-forked-h5d7yz?file=/src/index.js

It seems like the issue comes from this particular call:

import { shouldPolyfill } from "@formatjs/intl-displaynames/should-polyfill";

const foo = shouldPolyfill("fr");

With 6.6.1 I am getting foo = "fr" which is expected.
With 6.6.2 I am getting foo = "br" which is the short code for a regional French language (breton). This is not correct.

Because of this bug my app is not loading @formatjs/intl-displaynames/locale-data/fr.

from formatjs.

github-actions avatar github-actions commented on June 2, 2024 1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from formatjs.

longlho avatar longlho commented on June 2, 2024 1

kk this issue is due to the list of supportedLocales is assumed to be ordered which for polyfills they aren't. Will fix soon.

from formatjs.

longlho avatar longlho commented on June 2, 2024

can u provide a codesandbox?

from formatjs.

gzurbach avatar gzurbach commented on June 2, 2024

Long story short, I had to replace:

const foo = shouldPolyfill("fr");
await import(`@formatjs/intl-displaynames/locale-data/${foo}`);

by:

const foo = shouldPolyfill("fr");
await import(`@formatjs/intl-displaynames/locale-data/fr`);

from formatjs.

gzurbach avatar gzurbach commented on June 2, 2024

As far as I know this issue is not resolved, and should not be closed.

from formatjs.

github-actions avatar github-actions commented on June 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from formatjs.

longlho avatar longlho commented on June 2, 2024

For posterity, the problem is the list of supported locales have both br & fr but was sorted alphabetically. fr - br has a match score of 250 but because fr's index was more than 250 below br, the penalty kicks in and knock it down to 259.

from formatjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.