Comments (4)
We could create a 'RootTabBarViewController' use it as the base class and subscribe to UITableBarControllerDelegate. I'd optional bind the tabBar in viewDidLoad, and create a refresh method, that would be overridden. I noticed the DevWebViewController is currently only used on the NotificationVC, maybe we could merge the two?
from dev-ios.
@JacobBoyd I sort of have to hedge everything I say against still being pretty newbie in iOS, but what you're describing makes sense to me. I'll have a better grip if I can review a PR. And if it leads to the expected behavior without hiccup, I'd love to merge it!
The overall code footprint is pretty small altogether for the app so far, so I'm not too concerned with imperfect architecture as long as the code stays readable. So if we move things around a bunch while we figure it out, it's alright with me!
from dev-ios.
Awesome! I have some prelim. changes I made this morning posted on my fork, but thought of additional changes I want to make before posting the PR!
from dev-ios.
Can't wait @JacobBoyd!
from dev-ios.
Related Issues (20)
- Weekly Digest (6 January, 2020 - 13 January, 2020)
- Weekly Digest (13 January, 2020 - 20 January, 2020)
- Weekly Digest (20 January, 2020 - 27 January, 2020)
- Weekly Digest (27 January, 2020 - 3 February, 2020)
- Trigger native audio play
- Trigger native video play
- Fix colors in safe area HOT 3
- Weekly Digest (3 February, 2020 - 10 February, 2020)
- Universal links not working when the app isn't installed HOT 6
- Add "skip ahead 15 seconds" to lock screen player. HOT 3
- Maintain audio playback speed if paused/played HOT 1
- Improve metadata message from native bridge
- White Lines on Top and Bottom of App in Dark Mode HOT 2
- Hacktoberfest Topic HOT 1
- Support all available themes HOT 3
- Migrate to Swift Package Manager HOT 2
- Dev Digest Links Don't Open in iOS App HOT 2
- Add cover image bug on Dev-ios / ForemWebView-iOS local build HOT 1
- App crashes when I navigate between tabs HOT 1
- Small adjustment to help with refreshing home page experience HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dev-ios.