Coder Social home page Coder Social logo

Comments (5)

ayuhito avatar ayuhito commented on June 8, 2024 1

Good catch! This is a bug with the website rather than the actual files itself. We weren't updating the CSS to point to the italic variants when switching the style. I'll look into it.

from fontsource.

wonrax avatar wonrax commented on June 8, 2024 1

Thanks for your work. I think this is why Google Fonts displays all the variants on the same page instead of organizing into categories (i.e. normal and italic).

from fontsource.

wonrax avatar wonrax commented on June 8, 2024

I just went to look for other fonts and discovered that actually all of them don't have any italic version while the ones on Google Fonts do. This seems to be a larger problem than a single font's mistake.

This is the Playfair Display font with the Regular Italic variant on Google Fonts:
image

And this is the Playfair Display Regular on Fontsource with italic style enabled:
image

I don't know why the Fontsource's font curator made the decision to exclude the italic variants when generating and bundling fonts, but for people that use the italic variant for display, this really matters. If you slap a font-style: italic on a regular variant, it doesn't look the same as using the italic variant.

from fontsource.

ayuhito avatar ayuhito commented on June 8, 2024

This should be fixed with #927. However, just noting that you will notice Libre Baskerville 700 Italic won't load, which is a separate bug tracked in #855 where some fonts support 400, 400i, 700 but not 700i.

from fontsource.

ayuhito avatar ayuhito commented on June 8, 2024

Yup, the issue stems deeper for us since our original API implementation didn't consider this to be a possibility, so it's a little difficult to workaround with since our website relies on said API.

from fontsource.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.