Comments (4)
psanders
commented on May 22, 2024
1
I recommend adding the correct method and keeping the old one (with a deprecation notice). Then, all implementations will need to implement the new method name and maintain the old one as an "alias" until the deprecation is complete.
Leaving all known implementations here, for reference:
https://github.com/fonoster/fonoster/tree/main/mods/googletts
https://github.com/fonoster/pollytts
https://github.com/fonoster/fonoster/tree/main/mods/marytts
from fonoster.
gad2103
commented on May 22, 2024
i'm happy to take this on. however, it has downstream effects on at least Rox and anywhere else the lib is imported. how do you recommend fixing across all usage sites where the interface is being implemented?
from fonoster.
BrayanMnz
commented on May 22, 2024
Issue still open but has been already merged in pull/264/commits
Should this issue be closed or something is missing ?
from fonoster.
psanders
commented on May 22, 2024
Issue still open but has been already merged in pull/264/commits
Should this issue be closed or something is missing ?
Good catch. There is no reason to keep this open. Thanks
from fonoster.
Related Issues (20)
- Error when logout in the command-line tool
- Help identify the current project on the CLI HOT 3
- Unable to originate call with the CallManager HOT 6
- Unable to Authenticate (13 INTERNAL: Received RST_STREAM with code 0) using default docker setup method HOT 16
- PR template not showing for new PRs HOT 4
- Docker installation not working HOT 1
- Nigeria E.164 Landline Numbers Error HOT 12
- Trouble setting up a SIP Trunk HOT 1
- Experimental Functions document missing HOT 2
- What are the correct way to configure external SIP to send call to Fonoster HOT 1
- Voice Service Error Feedback Issue HOT 1
- Excessive repetition of transfer message during call transfer process HOT 2
- Request to Update Twitter Icon to X HOT 2
- The test call does not connect HOT 1
- The console URL shows a spinner HOT 1
- Specification for playing wav files HOT 4
- Test call does not connect
- The provider is not registered HOT 1
- Docker Installation Not Working HOT 1
- Authentication Issue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fonoster.