Moving more logic to the Auth service ? about angular-client-side-auth

[fnakstad]

Yep! You read my mind :) I'm actually working on a bigger refactoring of both the server and client side code, part of which encompasses putting more of the authentication/authorization specific stuff into the Auth service. So expect a bigger update before the week is over!

[wladston]

Awesome! I'll watch closely. I'll also try to make my own version of the Auth service while you finish yours.

[fnakstad]

Cool! Definitely let me know if you have any other issues or ideas to make the solution better :)

[wladston]

I do have a few, but I'll wait for you to release your updated version, maybe you already tackled them. As soon as I commit my implementation I'll send it to you as well (I'm doing a Bulletin Board).

[fnakstad]

Okay, I just pushed whatever I have right now though there will be more refactoring once I've cleared off some more pressing issues.

[wladston]

Awesome. Will check it out tonight.

[wladston]

One question: why do you get the cookie with the user name twice in the service.js ? In my local tests, the call in init is unnecessary ...

[wladston]

Here is my current implementation (considerably simpler than yours): https://github.com/wladston/mongobb

[fnakstad]

Ah, the init function isn't actually called anywhere. I simply forgot to remove it, but it's gone now :) It looks like we've done the exact same change in the login, logout, and register functions in the Auth service, so that's a good sign. I also moved some of the setup logic I used to have in my Angular run() handler to the Auth service instead, and added some functions (authorize, isLoggedIn) which I am using in the $routeChangeStart handler.

[wladston]

Allright. In time, I'm going to implement all of your features in my project too. Congratulations for the awesome work.