DNSFORWARDER issue about samba-domain

[systemofapwne]

This is indeed a bug in the init.sh script: By default, it adds the containers default DNS resolver, which is the docker DNS resolver. If DNSFORWARDER is set, it replaces

[global]

with

[global] dns forwarder = ....

But the culprit is, that another entry of "dns forwarder" is yet down the lines of the CFG, which will nullify the settings above and thus default back to the containers DNS resolver.

In order to fix this, init.sh only needs this additional line being added after

samba-domain/init.sh

Line 69 in 49d3588

if [[ $DNSFORWARDER != "NONE" ]]; then

sed -i "/dns forwarder/d" /etc/samba/smb.conf

This will first delete every single occurance of "dns forwarder" being generated by the previous commands, before adding the "dns forwarder" stated in the env DNSFORWARDER

[antonioj-mattos]

Hi @tbs575

I've had a similar problem, then looking at the config file at /var/lib/samba/config/samba/ I noticed the setting was being overridden at some point

[global]
        dns forwarder = 10.109.50.22
        idmap_ldb:use rfc2307 = yes
                        wins support = yes
 
        server role = active directory domain controller
        dns forwarder = 127.0.0.11  # <--- redefinition

It worked after I comment out the second definition.

[mtcoffee]

Hi @tbs575

I've had a similar problem, then looking at the config file at /var/lib/samba/config/samba/ I noticed the setting was being overridden at some point

[global]
        dns forwarder = 10.109.50.22
        idmap_ldb:use rfc2307 = yes
                        wins support = yes
 
        server role = active directory domain controller
        dns forwarder = 127.0.0.11  # <--- redefinition

It worked after I comment out the second definition.

Had the same issue but in /etc/smb.conf

[Fmstrat]

@meatsac @tbs575 Are either of you using an external config? Can you send in your compose file? I think this may be related to the cp issue, or it's getting replaced on provision.

[sasa-friedrich-bitlab]

I can confirm same thing (dns forwarder written twice). Here is my docker-compose.yml:

version: '2'

networks:
  samba-pdc:
    external: true

services:

  samba:
    image: samba-domain:latest
    container_name: samba-dc
    volumes:
      - /etc/localtime:/etc/localtime:ro
      - ./data/:/var/lib/samba
      - ./config/:/etc/samba/external
    environment:
      - DOMAIN=TEST.LOCAL
      - NOCOMPLEXITY=true
      - DOMAINPASS=test123
      - DNSFORWARDER=8.8.8.8
      - HOSTIP=192.168.100.2
    networks:
      - samba-pdc
    ports:
      - 192.168.100.2:53:53
      - 192.168.100.2:53:53/udp
      - 192.168.100.2:88:88
      - 192.168.100.2:88:88/udp
      - 192.168.100.2:135:135
      - 192.168.100.2:137-138:137-138/udp
      - 192.168.100.2:139:139
      - 192.168.100.2:389:389
      - 192.168.100.2:389:389/udp
      - 192.168.100.2:445:445
      - 192.168.100.2:464:464
      - 192.168.100.2:464:464/udp
      - 192.168.100.2:636:636
      - 192.168.100.2:1024-1044:1024-1044
      - 192.168.100.2:3268-3269:3268-3269
    dns_search:
      - test.local
    dns:
      - 192.168.100.2
      - 192.168.100.1
    extra_hosts:
      - dc.test.local:192.168.100.2
    hostname: dc
    cap_add:
      - NET_ADMIN
    devices:
      - /dev/net/tun
    privileged: true
    restart: always

[cadeon]

Me too, dns forwarder twice in the external smb.conf, with two different values. However - for me, commenting the second entry doesn't change behavior.

Getting shell into the container shows the issue exists in /etc/samba/smb.conf and /etc/samba/external/smb.conf. I have external mapped as a volume and was correcting the external version, but it wasn't being copied over. I manually copied it over in the container, and now we're forwarding.

[mvthul]

How can I fix this permanently? Wich one to edit and were I see 3 smb.conf locations in this thread xD

[mvthul]

How can I fix this my setup just isn’t Forward queries that can not be answered from own zones.
Cant resolve example bing.com somehow

[mvthul]

Okee I remove the second entry only in sed -i "/dns forwarder = dcipaddress" /etc/samba/smb.conf and changed the smb.conf in the samba/config/samba/smb.conf to the forwarded ip

[infeeeee]

This bug is not resolved yet.

@systemofapwne can you create a PR? is it ok for you if I create it?

[systemofapwne]

This bug is not resolved yet.

@systemofapwne can you create a PR? is it ok for you if I create it?

Please create a PR yourself. I am not using this container anymore, since it gave me too much headaches and was using an outdated Samba version for quite some time. I fully migrated to a VM running Univention UCS for my AD.

[helgeklein]

This is still unfixed.

[frasou]

This is still unfixed.

First of all, try develop branch. Many issues are "solved" there. Master is quite outdated and full of bugs. I don't know the reason though, why maintainer has not merged it to master.