Suspend / Force scanning about image-reflector-controller

[bigkevmcd]

For the second part (force-scan) I wonder if it wouldn't be useful to extract the predicate and annotation to be shared across services?

[squaremo]

For the second part (force-scan) I wonder if it wouldn't be useful to extract the predicate and annotation to be shared across services?

Yeah I think that's a good idea. There will probably still need to be code for deciding whether to do a scan, or if not, when to requeue. But it's a good habit to get into with the controllers, and will avoid some needless reconcile calls no doubt.

Side note: I initially didn't grok how scheduling via RequeueAfter would work with the filter. For the benefit of people as slow to catch on as I am, the predicate only pertains to the changes coming into the queue, and the scheduling works by requeuing directly.