[url_launcher] The windows demo is breaking `build_runner` builds because of `pigeon` about flutter

[huycozy]

Hi @feinstein
I checked this on a new Flutter project with adding only two package as mentioned, but couldn't see the issue:

➜  repro_147909 dart run build_runner watch -d
Building package executable... (10.6s)
Built build_runner:build_runner.
[INFO] Generating build script completed, took 435ms
[INFO] Precompiling build script... completed, took 5.4s
[INFO] Setting up file watchers completed, took 19ms
[INFO] Waiting for all file watchers to be ready completed, took 199ms
[INFO] Building new asset graph completed, took 1.5s
[INFO] Checking for unexpected pre-existing outputs. completed, took 1ms
[INFO] Generating SDK summary completed, took 6.7s
[INFO] Running build completed, took 20.2s
[INFO] Caching finalized dependency graph completed, took 110ms
[INFO] Succeeded after 20.3s with 48 outputs (100 actions)

Here are my dependencies:

dependencies:
  flutter:
    sdk: flutter


  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^1.0.6
  url_launcher: ^6.2.6
  json_serializable: ^6.8.0

dev_dependencies:
  flutter_test:
    sdk: flutter

  build_runner: ^2.4.9

Looks like you are using old versions, could you try upgrading them to the latest versions and retry?

[feinstein]

Sorry I will try, I ran pub upgrade, but forgot to check the latest versions.

[stuartmorgan]

[SEVERE] json_serializable on example/ios/.symlinks/plugins/url_launcher_ios/pigeons/messages.dart (cached):

You appear to have build_runner configured to iterate into .symlinks. That directory is part of the flutter build process, and any other use of it is unsupported. In this case, it would be comparable to including build or .dart_tool in your input set.

As a result of the above it appears to be iterating into all directories of all plugins in the dependency tree. The pigeons directory of url_launcher_ios is not part of its public interface, so using it is unsupported. As with any dependency, you should only be using things from lib, and if that constraint is violated the usage is not supported, and is subject to breakage at any time. Certainly if you are ending up with dev-only files of other packages as inputs (in violation of package conventions), it is expected that you would have issues if you don't include the dev dependencies of that package.

Closing as this is a configuration issue, not an issue with url_launcher.