Comments (5)
height and width are double, are you aware of any floating point number resolution?
AVPlayer returns video sizes using doubles (CGSize
), so using an int would potentially destroy information from the platform level. Given that, plus the fact that altering the type now would be a breaking change, we will be keeping double
as the type. Clients can always round if they are not concerned about potential loss of precision if there are cases where AVPlayer returns non-integer values.
from flutter.
@stephane-archer
Both, height
and width
are implemented as double
:
These properties are then being used in AspectRatio
as below:
Probably returning double
is more safe than returning these property values as int.
from flutter.
@darshankawar width
and height
are video resolution. the typical values would be 1920 and 1080 respectively. I don't think videos with 0,5 pixels exist. The associated AspectRatio
would be 16:9. here it makes sense to use a double
for this value but it's not because to calculate an AspectRatio
you need a floating point division that width
and height
should be defined as double
from flutter.
Thanks for the feedback.
from flutter.
@stuartmorgan Do you have any idea why AVPlayer would return video sizes using doubles? Do I miss something?
from flutter.
Related Issues (20)
- Problem with users paying via combini (Japan) HOT 1
- SegmentedButton: Proposal to modify / update redundant usage of `if` statement implementation HOT 2
- mac-23 lost external connection phone device. HOT 1
- mac-25 lost external connection phone device. HOT 1
- linux-45 is dead. HOT 2
- [flutter_markdown] Cannot Copy & Paste content inside markdown #105557 HOT 3
- Updating DefaultTabController with length greater than 2 in a StatefulWidget, then tapping the last tab, results in "setState() called after dispose()" exception HOT 2
- Add SecondaryTap callback to DataTable HOT 1
- Breakpoints skipped in unit tests when awaiting certain async calls HOT 2
- Execution failed for task ':gradle:compileGroovy' HOT 1
- linux-18 lost external connection phone device. HOT 1
- mac-24 lost external connection phone device. HOT 1
- [Impeller] slow frame in new gallery while navigating to travel application HOT 1
- Proposal: use "enhanced enums" in the repo for reduced boilerplate HOT 3
- mac-3 lost external connection phone device. HOT 1
- Add getter for floatingActionButtonLocation in ScaffoldState
- "One or more plugins require a higher Android SDK/NDK version" – tell me what these plugins are HOT 2
- [Impeller] Rendering difference using ImageFilter.matrix HOT 2
- mac-29 lost external connection phone device. HOT 1
- Directly access and communicate with printers on the Windows HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flutter.