Coder Social home page Coder Social logo

Comments (8)

jmagman avatar jmagman commented on June 2, 2024

@keyonghan This should only be needed for the test part, not build. Is the recipe the same for both?

from flutter.

vashworth avatar vashworth commented on June 2, 2024

@keyonghan This should only be needed for the test part, not build. Is the recipe the same for both?

Looking at the recipes code, looks like https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/devicelab/devicelab_test_drone.py is the recipe for the test part

from flutter.

keyonghan avatar keyonghan commented on June 2, 2024

The test part is using a separate recipes, but we may consider consolidating them.
Let me add the preparation logic to the recipe.

from flutter.

jmagman avatar jmagman commented on June 2, 2024

we may consider consolidating them

The build part doesn't need to happen on a devicelab machine, but in this case the test does.
Is there any work being done to move more tests to build/test?

from flutter.

keyonghan avatar keyonghan commented on June 2, 2024

The build part doesn't need to happen on a devicelab machine, but in this case the test does.

That's correct.

Is there any work being done to move more tests to build/test?

We are not pushing hard on this direction before we have the graph scheduler, with which the build and test separation will benefit the most. Otherwise, we are just moving the build time from a devicelab testbed to the VM (the execution time even increases more considering the whole orchestrator's waiting time in the whole run)

from flutter.

keyonghan avatar keyonghan commented on June 2, 2024

https://flutter-review.googlesource.com/c/recipes/+/54841 fixes this issue.

from flutter.

vashworth avatar vashworth commented on June 2, 2024

@keyonghan Follow up question, is there a reason we run this test in presubmit? I thought we tried to avoid running tests with physical iOS devices in presubmit?

from flutter.

github-actions avatar github-actions commented on June 2, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

from flutter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.