Comments (8)
@keyonghan This should only be needed for the test part, not build. Is the recipe the same for both?
from flutter.
@keyonghan This should only be needed for the test part, not build. Is the recipe the same for both?
Looking at the recipes code, looks like https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/devicelab/devicelab_test_drone.py is the recipe for the test part
from flutter.
The test part is using a separate recipes, but we may consider consolidating them.
Let me add the preparation logic to the recipe.
from flutter.
we may consider consolidating them
The build part doesn't need to happen on a devicelab machine, but in this case the test does.
Is there any work being done to move more tests to build/test?
from flutter.
The build part doesn't need to happen on a devicelab machine, but in this case the test does.
That's correct.
Is there any work being done to move more tests to build/test?
We are not pushing hard on this direction before we have the graph scheduler, with which the build and test separation will benefit the most. Otherwise, we are just moving the build time from a devicelab testbed to the VM (the execution time even increases more considering the whole orchestrator's waiting time in the whole run)
from flutter.
https://flutter-review.googlesource.com/c/recipes/+/54841 fixes this issue.
from flutter.
@keyonghan Follow up question, is there a reason we run this test in presubmit? I thought we tried to avoid running tests with physical iOS devices in presubmit?
from flutter.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v
and a minimal reproduction of the issue.
from flutter.
Related Issues (20)
- PopScope.canPop doesn't work HOT 3
- [Impeller] RenderTarget cache regressed A02 performance HOT 2
- BUG: Missing local_auth_ios when Using flutter SDK 3.16.8 and local_auth: 2.12.2 HOT 5
- xcode15 can run the virtual machine, but the real machine cannot run successfully Command PhaseScriptExecution failed with a nonzero exit code HOT 5
- Vertical stepper shows line after last step HOT 2
- Wrong display on Android with PlatformViewLink HOT 5
- app crashes in ios 17.0 HOT 1
- [packages/two_dimensional_scrollables] Error: '_leadingXIndex != null': is not true. HOT 2
- [material/menu_anchor.dart] Tab focus stopped at SubmenuButton HOT 1
- checkerboardoffscreenlayers = true doesn't work. HOT 1
- [flutter_markdown] MarkdownElementBuilder Fails to Support WidgetSpans in Text.rich HOT 3
- [material/menu_anchor.dart] Directional focus causes strange focus order with overlapping menus. HOT 2
- [cupertino/button.dart] CupertinoButton does not contain FocusNode and is not focusable. HOT 3
- Error when combining scrolling and pull-to-refresh in Debug HOT 1
- [material/menu_anchor.dart] '_anchor != null': is not true when wrapped with CupertinoContextMenu HOT 5
- IconButton.constraints does not apply the default constraints HOT 6
- impossible to produce Wasm-only Web build using Flutter tool HOT 2
- itemExtentBuilder: too many unnecessary calls HOT 1
- Flutter as a platform for building cross VR experiences HOT 2
- Canvas.saveLayer emits tracing is flaky HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flutter.