Coder Social home page Coder Social logo

Comments (3)

TankredO avatar TankredO commented on July 20, 2024

The thinning in this function works differently than the thinning in getSample etc.. Maybe it would make sense to abstract the thinning into an utility function and use it everywhere.

from bayesiantools.

florianhartig avatar florianhartig commented on July 20, 2024

I don't think that's necessary, I think thin was simply the wrong word for this, in line with the logic of getSample this could simply be renamed into nSamples.

While you're at it, however, could you check

a) that this works

b) what happens if nSamples is smaller than number of samples available in the chain (might be necessary to catch this in get Sample)

from bayesiantools.

TankredO avatar TankredO commented on July 20, 2024

Should be save now: 3b4db45.
Also, thin was renamed to numSamples to be consistent with getSample.

from bayesiantools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.