Pre-deploy hooks about whiskey_disk

[rick]

Thanks, Magnus --
I'll try to look at this on the plane back from SF this week.
Rick

[rick]

I didn't get a chance to get to this on the plane. A couple of clarifying questions now that I'm thinking more about it:

I read your pre-deploy state as:

• working from the prior version
• having already done a git fetch for the main repo

I'm not sure which .whiskey_disk-files you're asking for -- do you mean the files which track changes? For a single repo this would be possible (as that's deducible via git from the hashes of the current HEAD and the new origin/ HEAD), but for information from the other repositories it would be harder (as that information comes from applying those files, currently via rsync).

I'm mentally walking myself through the "business value" of the three preconditions. Having the previous version checked out seems obvious to me (and would be the state I think most people would expect the checkout to be in); having origin/ available (i.e., post-fetch) seems reasonable, as then one could do one's own arbitrary comparisons as to state. If it's changes files we're discussing in #3 then that might also be useful, it just happens to be (quite?) a bit more difficult.

Thoughts?

Rick

[judofyr]

Let me rephrase my third "requirement": I want to be able to use changes? in my pre-deploy hook.

Also, when I think about it, shouldn't the pre-deploy hooks run on all the machines before any of them start on the deployment? Ugh, this seems harder than I thought :/

[rick]

Gotcha. I'm doing some work that will allows #changes? to work in the pre-deploy hooks. The synchronization bit is on the radar for other reasons, but may take a bit to get done.

[judofyr]

Great. And thanks for some great work on whiskey_disk :-)