the normalize method removes zeros if there are before about phony

[bogdanRada]

maybe this number should not be considered plausible or this is a issue with normalization. I am not exactly sure so please let me know what should it be and how can be fixed if there is any solution. Thank you very much.

[floere]

Hi Bogdan,

That is one strange number – looking at http://en.wikipedia.org/wiki/Telephone_numbers_in_Egypt I can tell it does not really exist. Would you agree?

Plausible only tells you with 100% certainty that a number is wrong (https://github.com/floere/phony#plausibility). As an FYI. Here, it probably should return false, you're right.

Regarding normalize:
In all (I've seen) countries, zeroes after the country code indicate a trunk prefix (http://en.wikipedia.org/wiki/Trunk_prefix), with the exception of North American Codes. And there is usually the one zero. Followed by something that is not a trunk code number (most times not zero). People sometimes accidentally type in another zero, which normalize conveniently cleans up for them. This is what happened in your case. I decided to err on the side of convenience.

Btw, the latest code uses country specific trunk codes: https://github.com/floere/phony/blob/master/lib/phony/national_code.rb#L33 (Documentation not yet updated).

To sum up:

• We should check for too many trunk code numbers and return plausible false if there is more than one.
• Phony.plausible? can do only so much, sometimes numbers are just incorrect. Not often so, but how would it know that some number does not exist.

Cheers & thanks,
Florian

[bogdanRada]

thanks for the quick response. I agree that number might not exist but is just an example .
I do understand now the use of the trunk codes and you are probably right.
Thanks for the update.