incorrect normalization about phony

[floere]

Thanks for the issue. However, for this to be a useful issue entry, it needs more information:

As a bare minimum: What was your expectation? What are your assumptions underlying that expectation?

[xn]

I'm in the US, we would expect that number to be "6505615158" a three digit area code, followed by a three digit exchange and then a four digit ID.

[floere]

Hi Christian,

Phony is an international phone number library (see README). When it looks at your number, it sees a number from Singapore (since it starts with 65). It then correctly concludes that the 0 is erroneous and removes it.

It has no possibility of magically deducing that your number is an incorrect US E164 number and auto correcting, adding a US country code of 1. You need to tell it that it is looking at a US number.

So with the correct country code added:

Phony.normalize("1 650 561 5158") # => "16505615158"
Phony.formatted("16505615158") # => "[phone]"

I hope that helps. Cheers!

[xn]

Thanks. I appreciate your time.

[floere]

My pleasure. One idea is to simply add a 1 if there isn't one at the beginning already if you know you only have US numbers:

number = Phony.normalize(number =~ /\A1/ ? number : "1#{number}")