Coder Social home page Coder Social logo

Comments (5)

floere avatar floere commented on August 18, 2024

Thanks for reporting! Inclined to fix it and send a pull request? :)

On 24.01.2012, at 15:05, Bekki Hui [email protected] wrote:

A number like "390612345678" will not format correctly. The last digit will be dropped and the formatted number will end up looking like this: "+39 06 123 4567"

The problem is in the last handler defined in phony/countries/italy.rb. The local splitter there will split the number into three digits and then four, dropping off the last digit. This works just fine for 3 or more digit NDCs obviously. :)


Reply to this email directly or view it on GitHub:
#33

from phony.

bekki avatar bekki commented on August 18, 2024

Will do!

from phony.

floere avatar floere commented on August 18, 2024

Thank you, Bekki!

from phony.

floere avatar floere commented on August 18, 2024

@PixelVixen Ok, pulled your request. Thanks very much for participating!

As a note for the future: The countries specs are in spec/lib/phony/countries_spec.rb and can be run with rake spec after a bundle install. Cheers!

Will release 1.6.2 in the next half hour.

from phony.

floere avatar floere commented on August 18, 2024

Phony 1.6.2 is released, also see contributors https://github.com/floere/phony/wiki/Contributors. Thanks! :)

from phony.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.