Argentina phone number formatting is quite broken about phony

[floere]

Thanks! It is horribly broken indeed, with a big fat TODO on top.

I'll think about a quick solution and pasting it here (for reference). Cheers!

[floere]

Thanks for the test cases and the detailed writeup as well!

[vilcsak]

Is there another country that has a similar setup with the area codes? If there's an existing case, I can probably figure things out.

[floere]

Lithuania might be helpful, but I have to admit that I am wondering how to do the mobile numbers. Argentina is pretty unique in that they prepend a "mobile digit" in front of the normal numbering scheme.

[floere]

This solves the case for fixed line numbers:

  country '54', one_of('11') >> split(4,4) |
                one_of("220",
                       "221",
                       "223",
                       "237",
                       "261",
                       "264",
                       "291",
                       "297",
                       "299",
                       "341",
                       "342",
                       "343",
                       "345",
                       "351",
                       "353",
                       "358",
                       "381",
                       "385",
                       "387",
                       "388") >> split(3,4) |
                fixed(4)      >> split(2,4)

[floere]

@vilcsak Can you live with mobile number rendered as "[phone]"? (no space between 9 and 11) I need to do a little rewrite of Phony if this case needs to be covered.

[floere]

(Please disregard my earlier attempt at a regexp – I was in the wrong mindset)

[floere]

Got it, will release in 1.5.2 in 10 minutes.

  # Argentine Republic.
  #
  country '54', one_of('11', '911') >> split(4,4) | # Fixed & Mobile
                match(/^(22[0137]|237|26[14]|29[179]|34[1235]|35[138]|38[1578])/) >> split(3,4) |        # Fixed
                match(/^(922[0137]|9237|926[14]|929[179]|934[1235]|935[138]|938[1578])/) >> split(3,4) | # Mobile
                match(/^(9\d{4})/) >> split(2, 4) | # Mobile
                fixed(4) >> split(2,4) # Fixed

[vilcsak]

Cool, this will certainly do for now. Would be great to have the true 9 support in the future.

[floere]

Great! 1.5.2 is released, fixed with your input. Many thanks!

[vilcsak]

Upgraded, thanks!

[floere]

@vilcsak Great! Please note that 1.6.0 has been released as well, lowering the possibility of cut-off numbers. Also find yourself in the special mentions section https://github.com/floere/phony/wiki/Contributors :)

[floere]

Btw, I love the title "quite broken" … it's like the brits say "quite dead" :)