Comments (3)
Hi,
Before we can accept a patch from you we have to ask you to sign a CLA as
described
in http://code.google.com/p/googletest/wiki/GoogleTestDevGuide.
A note on the patch: as MinGW provides the Win32 API, it makes sense to tag
MinGW
platform with GTEST_OS_WINDOWS compiler symbol in gtest-port.h:
...
#elif defined(_WIN32) || defined(__MINGW32__)
#define GTEST_OS_WINDOWS 1
...
This will lead to a simpler patch, I believe.
Regards,
Vlad
Original comment by vladlosev
on 19 Sep 2009 at 8:40
- Added labels: OpSys-All, Priority-Low
- Removed labels: Priority-Medium
from googletest.
I'd rather not sign anything. You can take it or leave it. At the very least
perhaps you can see what needs to be done to make it work properly.
Original comment by [email protected]
on 21 Sep 2009 at 4:11
- Added labels: ****
- Removed labels: ****
from googletest.
Kenton Varda contributed a patch to fix gtest on minGW. It is in the trunk. I
just
verified that the trunk head works on minGW.
Original comment by [email protected]
on 22 Sep 2009 at 8:41
- Changed state: Fixed
- Added labels: OpSys-Windows, Type-Enhancement, Usability
- Removed labels: OpSys-All, Type-Defect
from googletest.
Related Issues (20)
- need EXPECT_THAT and matchers from googlemock HOT 2
- need to get rid of the use of UnitTestAccessor in the event API samples before releasing 1.4.0 HOT 1
- ParseGoogleTestFlagsOnlyImpl implementation issue HOT 2
- Assertion messages printed twice on Windows CE HOT 2
- Long assertion messages don't show up on Windows CE HOT 3
- Elapsed time on Windows CE does not work correctly HOT 3
- Using RecordProperty without XML output HOT 1
- RecordProperty support for double/bool/char/etc HOT 1
- need to check whether our uses of GTEST_SUPPRESS_UNREACHABLE_CODE_WARNING_BELOW_ are OK HOT 2
- GCC compilation error "error: conversion from `void' to non-scalar type" HOT 4
- Even if all tests using a fixture class are DISABLED_ SetUp() still seems to be run. HOT 7
- Gtests run under Visual Studio but not under Team Build HOT 4
- Build Issues in VS2005 HOT 2
- Ehance upload_gtest.py to support http proxy HOT 1
- Adding Symbian Project Definition File HOT 7
- Extended SCOPED_TRACE HOT 4
- ASSERT_DOUBLE_EQ(0.0, x) fails for 0 < x < std::numeric_limits<double>::epsilon() HOT 1
- ASSERT_STRCASEEQ and ASSERT_STRCASENE macros should compare strings consistently across platforms
- Should report the source file location of the TEST that throws an exception
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from googletest.