Coder Social home page Coder Social logo

Comments (3)

GoogleCodeExporter avatar GoogleCodeExporter commented on July 26, 2024
Hi,

Before we can accept a patch from you we have to ask you to sign a CLA as 
described
in http://code.google.com/p/googletest/wiki/GoogleTestDevGuide.

A note on the patch: as MinGW provides the Win32 API, it makes sense to tag 
MinGW
platform with GTEST_OS_WINDOWS compiler symbol in gtest-port.h:
...
#elif defined(_WIN32) || defined(__MINGW32__)
#define GTEST_OS_WINDOWS 1
...

This will lead to a simpler patch, I believe.

Regards,
Vlad

Original comment by vladlosev on 19 Sep 2009 at 8:40

  • Added labels: OpSys-All, Priority-Low
  • Removed labels: Priority-Medium

from googletest.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 26, 2024
I'd rather not sign anything.  You can take it or leave it.  At the very least
perhaps you can see what needs to be done to make it work properly.

Original comment by [email protected] on 21 Sep 2009 at 4:11

  • Added labels: ****
  • Removed labels: ****

from googletest.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 26, 2024
Kenton Varda contributed a patch to fix gtest on minGW.  It is in the trunk.  I 
just 
verified that the trunk head works on minGW.

Original comment by [email protected] on 22 Sep 2009 at 8:41

  • Changed state: Fixed
  • Added labels: OpSys-Windows, Type-Enhancement, Usability
  • Removed labels: OpSys-All, Type-Defect

from googletest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.