Accept a username in Redis configuration about flipt

[markphelps]

@thepabloaguilar great catch! will add this

[erka]

Hey @thepabloaguilar. Do you plan to used it with OCI storage?

[thepabloaguilar]

Yes, I do @erka

[erka]

@thepabloaguilar https://community.flipt.io/t/cache-and-reference-with-git-backend/14/2

[thepabloaguilar]

I don't think I've understood completely @erka, the cache for OCI storage I get it (it's already in memory) but I thought the cache also will be used to cache flags evaluation results! Is my last statement wrong?

[erka]

@thepabloaguilar I think it's only used on storage level.

flipt/internal/cmd/grpc.go

Lines 193 to 201 in bc3f7be

	cacher, cacheShutdown, err = getCache(ctx, cfg)
	if err != nil {
	return nil, err
	}
	server.onShutdown(cacheShutdown)
	store = storagecache.NewStore(store, cacher, logger)

[markphelps]

yeah it caches the data used in the evaluation, but not the evaluation results themselves, as this would likely make the cache grow very large depending on usage patterns.

We could benchmark the results of evaluating using OCI storage with and without cache, but as George said in the linked community discourse, adding cache in front is unlikely to speed it up very much and may make it slower actually because the extra hop for Redis

[thepabloaguilar]

Got it @erka and @markphelps, maybe an update to the doc are required to maybe make it more clear to the readers like me 🥲

When I read the Storage - Caching session I thought it'll also cache the evaluations because of this items:

• All flag reads and evaluation requests go through the cache
• Evaluation cache entries are purged after the TTL expires only