Add json attribute to variants about flipt

[markphelps]

Thanks for taking this on and for the PR @amayvs ! I agree I think JSON would be better than storing binary.

Yes for the UI I was thinking we would have a textarea that is optional, and perhaps verify that it is proper JSON before submitting. We'd likely want to do that validation on the server side as well before accepting the JSON and perhaps put a limit to the number of bytes that can be stored?

[markphelps]

@kevin-ip honestly I think we can just hardcode the max of the attachment field to be 10kb or something similar. Then if we get a request to make it configurable we could do so later.

10kb of json is quite a lot for a single field I think

I was thinking something like this which I guess does make sense to be in the variant validator

const MAX_VARIANT_ATTACHMENT_SIZE = 10000

bytes, err := json.Marshal(req.Attachment)
if err != nil { ... }

if len(bytes) > MAX_VARIANT_ATTACHMENT_SIZE {
  return errs.InvalidFieldError("attachment", "max json payload size is 10kb")
}

or something similar?

That way we don't have to modify the validator itself to pass in the context or add a new config property

[4n70w4]

reference: https://checkr.github.io/flagr/#/flagr_use_cases?id=dynamic-configuration

[markphelps]

@4n70w4 thanks for the feature request. I think I can see the value in this, wondering if you think this attachment field should support strictly JSON or any value (like a blob).

Reason being, I don't want to get into validating user input as JSON, but perhaps I dont need to. Whatever the user saves as the value could be returned as an attachment.

What are your thoughts?

[4n70w4]

@markphelps yes you're right, may be do payload in any format.

[amayvs]

Hi @markphelps, we are currently working on this feature and wanted to get some input about how the field should be represented in the UI.

As per the comments above, we've implemented attachment field as a bytearray, do we expect the UI to have a simple textarea where user can copy/paste data or does it need to do any encoding/decoding?

But we feel that the field would be better served as JSON, and if binary attachment is required, it can be base64 encoded and included to the JSON structure.

Additionally, if you have other general thoughts about this feature then do let us know. Thanks.

Draft PR: #685

[kevin-ip]

Hi @markphelps, What would you recommend the default limit to the number of bytes?

I am planning to add a new config, DataConfig (default with 1024 KB), and updating the Validator.Validate() to take a context.Context. The ValidationUnaryInterceptor will set the ctx with dataConfig before invoking Validator.Validate(...). The method will then get the config from the context and compare against the length of the attachment. WDYT?