Comments (5)
A way to easily reproduce this crash is to force _displayLink to nil on stop animating like so:
- (void)stopAnimating
{
_displayLink = nil;
if (self.animatedImage) {
self.displayLink.paused = YES;
} else {
[super stopAnimating];
}
}
from flanimatedimage.
After some research it seems obj_storeWeak
is crashing when the object getting assigned is being deallocated. Changing FLWeakProxy's target object storage from weak to assign works, but it's definitely non-optimal, but now it's beyond my Objective-C knowledge in order for me to help more :(
from flanimatedimage.
-stopAnimating
creating displayLink
is problematic (it wouldn't _re_create it, as it never gets nil'ed out, but rather would create it the first time -- this could happen when you never started animating it before it goes away) and we have a straight-forward fix for it within the day. Thanks for pointing this issue out! We were never running into this edge-case the way we're using the views.
On your last note, we wouldn't want to lose the properties of a weak reference because switching to assign could lead to dangling pointers. The issue you're seeing is the "weak system" crashing when trying to grab a reference to an object half-way through deallocation. This will be addressed with the fix described above.
Thanks again & stay tuned, just reviewing the fix!
from flanimatedimage.
@raphaelschaad Thanks for your timely response! 🎉
from flanimatedimage.
This got fixed with PR #24 merged to master!
from flanimatedimage.
Related Issues (20)
- Bug Report HOT 1
- the image can not be displayed for ios 14. HOT 2
- Adding as SPM package issue
- Single-frame GIF has rendering issues on iOS 14 HOT 2
- 播放速度秒数对不上问题 HOT 3
- Hardcoded Frame Rate Divisor HOT 3
- loopCompletionBlock does not work HOT 1
- 在iPhone13Promax播放帧率异常加快 HOT 5
- iPhone 偶尔 crash , ios14.8 or iOS 15.0,FLAnimatedImage initWithAnimatedGIFData:optimalFrameCacheSize:predrawingEnabled:]
- 在iPhone13 promax播放GiF图异常问题修复后,非GIF图片不能正常显示。 HOT 1
- 播放速度过慢如何调整 HOT 2
- Bitcode not enabled for package
- Hi, is there the latest version released? HOT 2
- why do i can't pod search FLAnimatedImage 1.0.17 HOT 2
- Crash in imageAtIndex
- How do i stream a gif so that it plays like it would in the browser
- FLAnimatedImage
- Xcode 14.3 Support
- Feature Request: Support App Privacy Manifest HOT 1
- Upload Privacy Policy HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flanimatedimage.