Crash on dealloc on animating image about flanimatedimage

[vinibaggio]

A way to easily reproduce this crash is to force _displayLink to nil on stop animating like so:

- (void)stopAnimating
{
    _displayLink = nil;
    if (self.animatedImage) {
        self.displayLink.paused = YES;
    } else {
        [super stopAnimating];
    }
}

[vinibaggio]

After some research it seems obj_storeWeak is crashing when the object getting assigned is being deallocated. Changing FLWeakProxy's target object storage from weak to assign works, but it's definitely non-optimal, but now it's beyond my Objective-C knowledge in order for me to help more :(

[raphaelschaad]

-stopAnimating creating displayLink is problematic (it wouldn't _re_create it, as it never gets nil'ed out, but rather would create it the first time -- this could happen when you never started animating it before it goes away) and we have a straight-forward fix for it within the day. Thanks for pointing this issue out! We were never running into this edge-case the way we're using the views.

On your last note, we wouldn't want to lose the properties of a weak reference because switching to assign could lead to dangling pointers. The issue you're seeing is the "weak system" crashing when trying to grab a reference to an object half-way through deallocation. This will be addressed with the fix described above.

Thanks again & stay tuned, just reviewing the fix!

[vinibaggio]

@raphaelschaad Thanks for your timely response! 🎉

[raphaelschaad]

This got fixed with PR #24 merged to master!