Comments (6)
Great catch. Curious that NSNumber
doesn't do "the right thing" here.
We could use a small enough epsilon to let the minimum slide (but not much beyond that) e.g. by defining const CGFloat kEpsilon = 0.00001;
or using the constant FLT_EPSILON
. But I never liked mocking "manually" with float comparisons.
Any suggestions?
from flanimatedimage.
What if we clamp kDelayTimeIntervalMinimum
to float so both types match when comparing? I just tested this and it works fine.
if ([delayTime compare:[NSNumber numberWithFloat:kDelayTimeIntervalMinimum]] == NSOrderedAscending) {
// ...
}
Fun stuff to read: https://github.com/opensource-apple/CF/blob/master/CFNumber.c#L1347
from flanimatedimage.
Interesting, so if I interpret the Core Foundation code correctly, all NSNumber
does is upcasting floats to doubles when comparing.
If we go the route of "normalizing" by down casting to float -- which is what I tried to avoid by just letting NSNumber
do "the right thing" --, it seems more straight-forward to just do it by (float) kDelayTimeIntervalMinimum
and then comparing with less than.
Does that capture the case with your test GIF?
from flanimatedimage.
That should work.
from flanimatedimage.
Could you verify it addresses the case with your specific GIF? If yes, would you like to open a pull request with the change? I'm happy to merge it in.
Let me know if you'd prefer me doing it.
from flanimatedimage.
Sure, let me check. I can prepare PR, it's not a problem.
On Friday, July 18, 2014, Raphael Schaad [email protected] wrote:
Could you verify it addresses the case with your specific GIF? If yes,
would you like to open a pull request with the change? I'm happy to merge
it in.Let me know if you'd prefer me doing it.
—
Reply to this email directly or view it on GitHub
#20 (comment)
.
from flanimatedimage.
Related Issues (20)
- Bug Report HOT 1
- the image can not be displayed for ios 14. HOT 2
- Adding as SPM package issue
- Single-frame GIF has rendering issues on iOS 14 HOT 2
- 播放速度秒数对不上问题 HOT 3
- Hardcoded Frame Rate Divisor HOT 3
- loopCompletionBlock does not work HOT 1
- 在iPhone13Promax播放帧率异常加快 HOT 5
- iPhone 偶尔 crash , ios14.8 or iOS 15.0,FLAnimatedImage initWithAnimatedGIFData:optimalFrameCacheSize:predrawingEnabled:]
- 在iPhone13 promax播放GiF图异常问题修复后,非GIF图片不能正常显示。 HOT 1
- 播放速度过慢如何调整 HOT 2
- Bitcode not enabled for package
- Hi, is there the latest version released? HOT 2
- why do i can't pod search FLAnimatedImage 1.0.17 HOT 2
- Crash in imageAtIndex
- How do i stream a gif so that it plays like it would in the browser
- FLAnimatedImage
- Xcode 14.3 Support
- Feature Request: Support App Privacy Manifest HOT 1
- Upload Privacy Policy HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flanimatedimage.