flexcorelib / flexcore Goto Github PK

Compile fails on VC ++ 14, 14.1.

Do you plan to support the visual c ++ compiler?

Dear flexcore developers,

I just noticed a build error on Ubuntu 16.04:

In file included from /home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/clock.cpp:8:
In file included from /home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/../flexcore/scheduler/clock.hpp:11:
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/atomic:185:7: error: exception specification of explicitly defaulted default constructor does not match the calculated one
      atomic() noexcept = default;
      ^
/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/clock.cpp:16:26: note: in instantiation of template class 'std::atomic > > >' requested here
                virtual_clock::system::current_time((
                                       ^
In file included from /home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/clock.cpp:8:
In file included from /home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/../flexcore/scheduler/clock.hpp:11:
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/atomic:185:7: error: exception specification of explicitly defaulted default constructor does not match the calculated one
      atomic() noexcept = default;
      ^
/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/clock.cpp:20:26: note: in instantiation of template class 'std::atomic > > >' requested here
                virtual_clock::steady::current_time((
                                       ^
2 errors generated.

This is with clang-3.8, but using Ubuntu's gcc-5.4 yields a related problem:

/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/cyclecontrol.cpp: In instantiation of ‘fc::thread::cycle_control::cycle_control(std::unique_ptr):: [with auto:1 = fc::thread::periodic_task]’:
/usr/include/c++/5/type_traits:2346:26:   required by substitution of ‘template static std::__success_type()((declval<_Args>)()...))> std::__result_of_other_impl::_S_test(int) [with _Fn = fc::thread::cycle_control::cycle_control(std::unique_ptr)::; _Args = {fc::thread::periodic_task&}]’
/usr/include/c++/5/type_traits:2357:55:   required from ‘struct std::__result_of_impl)::, fc::thread::periodic_task&>’
/usr/include/c++/5/type_traits:2361:12:   required from ‘class std::result_of)::(fc::thread::periodic_task&)>’
/usr/include/c++/5/functional:2053:9:   required by substitution of ‘template std::function<_Res(_ArgTypes ...)>::function(_Functor) [with _Functor = fc::thread::cycle_control::cycle_control(std::unique_ptr)::;  = void;  = ]’
/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/../flexcore/scheduler/cyclecontrol.hpp:179:70:   required from ‘fc::thread::cycle_control::cycle_control(std::unique_ptr, ErrorFun) [with ErrorFun = fc::thread::cycle_control::cycle_control(std::unique_ptr)::]’
/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/cyclecontrol.cpp:21:22:   required from here
/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/cyclecontrol.cpp:21:21: error: cannot call member function ‘bool fc::thread::cycle_control::store_exception(fc::thread::periodic_task&)’ without object
                     })
                     ^
In file included from /home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/cyclecontrol.cpp:1:0:
/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/../flexcore/scheduler/cyclecontrol.hpp: In instantiation of ‘fc::thread::cycle_control::cycle_control(std::unique_ptr, ErrorFun) [with ErrorFun = fc::thread::cycle_control::cycle_control(std::unique_ptr)::]’:
/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/cyclecontrol.cpp:21:22:   required from here
/home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/../flexcore/scheduler/cyclecontrol.hpp:179:70: error: no matching function for call to ‘std::function::function(std::remove_reference)::&>::type)’
     : scheduler_(std::move(scheduler)), error_callback(std::move(err))
                                                                      ^
In file included from /home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/../flexcore/scheduler/scheduler.hpp:4:0,
                 from /home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/../flexcore/scheduler/cyclecontrol.hpp:5,
                 from /home/oleid/sync/prog/opencl/flexcore_cl/3rdparty/flexcore/flexcore/scheduler/cyclecontrol.cpp:1:
/usr/include/c++/5/functional:2054:2: note: candidate: template std::function<_Res(_ArgTypes ...)>::function(_Functor)
  function(_Functor);
  ^
/usr/include/c++/5/functional:2054:2: note:   template argument deduction/substitution failed:
/usr/include/c++/5/functional:2028:7: note: candidate: std::function<_Res(_ArgTypes ...)>::function(std::function<_Res(_ArgTypes ...)>&&) [with _Res = bool; _ArgTypes = {fc::thread::periodic_task&}]
       function(function&& __x) : _Function_base()
       ^
/usr/include/c++/5/functional:2028:7: note:   no known conversion for argument 1 from ‘std::remove_reference)::&>::type {aka fc::thread::cycle_control::cycle_control(std::unique_ptr)::}’ to ‘std::function&&’
/usr/include/c++/5/functional:2232:5: note: candidate: std::function<_Res(_ArgTypes ...)>::function(const std::function<_Res(_ArgTypes ...)>&) [with _Res = bool; _ArgTypes = {fc::thread::periodic_task&}]
     function<_Res(_ArgTypes...)>::
     ^
/usr/include/c++/5/functional:2232:5: note:   no known conversion for argument 1 from ‘std::remove_reference)::&>::type {aka fc::thread::cycle_control::cycle_control(std::unique_ptr)::}’ to ‘const std::function&’
/usr/include/c++/5/functional:2008:7: note: candidate: std::function<_Res(_ArgTypes ...)>::function(std::nullptr_t) [with _Res = bool; _ArgTypes = {fc::thread::periodic_task&}; std::nullptr_t = std::nullptr_t]
       function(nullptr_t) noexcept
       ^
/usr/include/c++/5/functional:2008:7: note:   no known conversion for argument 1 from ‘std::remove_reference)::&>::type {aka fc::thread::cycle_control::cycle_control(std::unique_ptr)::}’ to ‘std::nullptr_t’
/usr/include/c++/5/functional:2001:7: note: candidate: std::function<_Res(_ArgTypes ...)>::function() [with _Res = bool; _ArgTypes = {fc::thread::periodic_task&}]
       function() noexcept
       ^
/usr/include/c++/5/functional:2001:7: note:   candidate expects 0 arguments, 1 provided

Can you reproduce it at your end?

First , I think it's a awesome (more than great!!) project, satisfies what I imagined for a "DAG Framwork", such as DAG base, easy to use, support thread, and so on.
When I go deeply to this project, I am puzzled about some detail. The project use adobe forest to define a tree, but use a Graph to manage the connection, it seems that the forest-tree has nothing to do with the Graph-tree.
So what's the state of this project now? Is there any new version of this project? Or is there any more material about this project?
Hope to get an answer, because I really like it and want to go on to maintain it.

FlexCore as an Open Source Project does currently not have integration of travis CI.
I tried to write a travis.yml file in my fork but travis uses an ancient version of ubuntu and compiler + cmake need to be installed in a more modern version.

I got it as far as to install clang and gcc in the proper version, but failed to get cmake 3.0+
( https://github.com/CasparKielwein/flexcore/blob/master/.travis.yml )

Hey,

when compiling flexcore on Archlinux, boost::log can't be found. FindBoost.cmake supplied with the repository comes with a list of known versions and dependencies. Adding my boost version (1.63) works fine, however, I'm wondering if it makes more sense to use the distribution's FindBoost to always make sure to have an updated list on a recent distribution.

Best,
Olaf

I can't figure out why should we create "a correct iterator" seems useless? Just want to add a corresponding node in forest?
But why should we need adobe forest if we already have connectable port and connect_graph?

// flexcore/extended/base_node.hpp
	template <class node_t, class... Args>
	node_t& make_child_impl(node_args nargs, Args&&... args)
	{
		//first create a proxy node to get the node_args with a correct iterator
		node_args n = new_node(std::move(nargs));
		//then replace proxy with proper node
		*n.self = std::make_unique<node_t>(std::forward<Args>(args)..., n);
		return dynamic_cast<node_t&>(**n.self);
	}