Coder Social home page Coder Social logo

Comments (4)

Pikanchion avatar Pikanchion commented on June 16, 2024

Incidentally, is it intentional that the width/height of a GPURender may not be set to 1?

from flaxengine.

mafiesto4 avatar mafiesto4 commented on June 16, 2024

Fixed in 1cb88bd.

from flaxengine.

Pikanchion avatar Pikanchion commented on June 16, 2024

@mafiesto4 This fixes cases where either width or height is less than 1, however, there are still two issues present:

  1. When both values are greater than 0 and at least one is equal to 1, there is an Unhandled exception: EXCEPTION_ACCESS_VIOLATION reading address 0x54.
Stack trace:
    at FlaxEditor.exe!GPUResource::SetName() in FlaxEngine\Source\Engine\Graphics\GPUDevice.cpp:line 239
    at FlaxEditor.exe!ScreenSpaceReflectionsPass::Render() in FlaxEngine\Source\Engine\Renderer\ScreenSpaceReflectionsPass.cpp:line 194
    at FlaxEditor.exe!ReflectionsPass::Render() in FlaxEngine\Source\Engine\Renderer\ReflectionsPass.cpp:line 452
    at FlaxEditor.exe!RenderInner() in FlaxEngine\Source\Engine\Renderer\Renderer.cpp:line 517
    at FlaxEditor.exe!Renderer::Render() in FlaxEngine\Source\Engine\Renderer\Renderer.cpp:line 213
    at FlaxEditor.exe!SceneRenderTask::OnRender() in FlaxEngine\Source\Engine\Graphics\RenderTask.cpp:line 391
    at FlaxEditor.exe!RenderTask::OnDraw() in FlaxEngine\Source\Engine\Graphics\RenderTask.cpp:line 84
    at FlaxEditor.exe!RenderTask::DrawAll() in FlaxEngine\Source\Engine\Graphics\RenderTask.cpp:line 46
    at FlaxEditor.exe!GPUDevice::Draw() in FlaxEngine\Source\Engine\Graphics\GPUDevice.cpp:line 632
    at FlaxEditor.exe!Engine::OnDraw() in FlaxEngine\Source\Engine\Engine\Engine.cpp:line 359
    at FlaxEditor.exe!Engine::Main() in FlaxEngine\Source\Engine\Engine\Engine.cpp:line 214
    at FlaxEditor.exe!wWinMain() in FlaxEngine\Source\Engine\Main\Windows\main.cpp:line 55
    at FlaxEditor.exe!__scrt_common_main_seh() in D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:line 288
    at KERNEL32.DLL 0x7ffa590e7344
    at ntdll.dll 0x7ffa594026b1
  1. When both values are greater than 1 and both are less than 8, there is an [Error] Critical error! Reason: Assertion failed! in FlaxEngine\Source\Engine\Core\Collections\Array.h, Line: 315: Expression: index >= 0 && index < _count.
Stack trace:
    at FlaxEditor.exe!Log::Logger::Write() in FlaxEngine\Source\Engine\Core\Log.cpp:line 260
    at FlaxEditor.exe!PlatformBase::Assert() in FlaxEngine\Source\Engine\Platform\Base\PlatformBase.cpp:line 451
    at FlaxEditor.exe!GPUTextureDX11::View() in FlaxEngine\Source\Engine\GraphicsDevice\DirectX\DX11\GPUTextureDX11.h:line 242
    at FlaxEditor.exe!PostProcessingPass::Render() in FlaxEngine\Source\Engine\Renderer\PostProcessingPass.cpp:line 320
    at FlaxEditor.exe!RenderInner() in FlaxEngine\Source\Engine\Renderer\Renderer.cpp:line 618
    at FlaxEditor.exe!Renderer::Render() in FlaxEngine\Source\Engine\Renderer\Renderer.cpp:line 213
    at FlaxEditor.exe!SceneRenderTask::OnRender() in FlaxEngine\Source\Engine\Graphics\RenderTask.cpp:line 391
    at FlaxEditor.exe!RenderTask::OnDraw() in FlaxEngine\Source\Engine\Graphics\RenderTask.cpp:line 84
    at FlaxEditor.exe!RenderTask::DrawAll() in FlaxEngine\Source\Engine\Graphics\RenderTask.cpp:line 46
    at FlaxEditor.exe!GPUDevice::Draw() in FlaxEngine\Source\Engine\Graphics\GPUDevice.cpp:line 632
    at FlaxEditor.exe!Engine::OnDraw() in FlaxEngine\Source\Engine\Engine\Engine.cpp:line 359
    at FlaxEditor.exe!Engine::Main() in FlaxEngine\Source\Engine\Engine\Engine.cpp:line 214
    at FlaxEditor.exe!wWinMain() in FlaxEngine\Source\Engine\Main\Windows\main.cpp:line 55
    at FlaxEditor.exe!__scrt_common_main_seh() in D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:line 288
    at KERNEL32.DLL 0x7ffa590e7344
    at ntdll.dll 0x7ffa594026b1

from flaxengine.

mafiesto4 avatar mafiesto4 commented on June 16, 2024

Fixed in 149a6a2.

from flaxengine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.