Coder Social home page Coder Social logo

Comments (15)

flavorjones avatar flavorjones commented on August 17, 2024 13

Punchlist

Things I think need to be done in order to complete deprecation, ideally by 2019-03-31:

from chromedriver-helper.

ioquatix avatar ioquatix commented on August 17, 2024 13

Thanks for being an awesome maintainer.

from chromedriver-helper.

flavorjones avatar flavorjones commented on August 17, 2024 8

v2.1.1 has been shipped with a post-install-message deprecation notice, and updated gemspec summary and description. Post-install message is:

  +--------------------------------------------------------------------+
  |                                                                    |
  |  NOTICE: chromedriver-helper is deprecated after 2019-03-31.       |
  |                                                                    |
  |  Please update to use the 'webdrivers' gem instead.                |
  |  See https://github.com/flavorjones/chromedriver-helper/issues/83  |
  |                                                                    |
  +--------------------------------------------------------------------+

from chromedriver-helper.

guilleiguaran avatar guilleiguaran commented on August 17, 2024 6

Changed in Rails, new Rails 6.0.0 apps will ship webdrivers instead of chromedriver-helper

from chromedriver-helper.

flavorjones avatar flavorjones commented on August 17, 2024 5

Rationale

  1. I have not coded in Rails or used chromedriver in quite some time, and so I'm pretty far from the day-to-day needs of most users of chromedriver-helper. To be honest, there are some design decisions that need to be made, and work that needs to be done; and I don't have the well-formed opinions or the motivation that a daily user of the gem might have.
  2. The webdrivers gem is well-maintained, is very nearly a superset of the functionality of this gem (and supports all major webdrivers), and further has maintainers interested in providing what little this gem does that's not already provided.
  3. There's value to the community in having one well-supported and well-maintained gem that handles a given concern; and IMHO there is little-to-nothing to innovate on in this space.

from chromedriver-helper.

EverybodyKurts avatar EverybodyKurts commented on August 17, 2024 4

Just wanted to say thank you for this gem and the good work you did. This gem helped me run integration tests in chrome and I didn't have to do a lot of setup or config. Great job.

from chromedriver-helper.

nodanaonlyzuul avatar nodanaonlyzuul commented on August 17, 2024 2

Thanks @flavorjones (and everyone else who has contributed) - enjoy that well earned, final punch-list item.

from chromedriver-helper.

connorshea avatar connorshea commented on August 17, 2024 1

@flavorjones you should include a message in the Changelog as well.

from chromedriver-helper.

lazlyhu avatar lazlyhu commented on August 17, 2024 1

Huge respect because the just released post-install-message! 🏅

from chromedriver-helper.

flavorjones avatar flavorjones commented on August 17, 2024

/cc @tenderlove for formal notification of rails-core contributors

from chromedriver-helper.

flavorjones avatar flavorjones commented on August 17, 2024

ruby-talk notification is at http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-talk/440018

from chromedriver-helper.

pixeltrix avatar pixeltrix commented on August 17, 2024

@guilleiguaran should we also backport that to 5-2-stable as well?

from chromedriver-helper.

hybridspyda avatar hybridspyda commented on August 17, 2024

Trying to upgrade to using the webdrivers gem instead, running into issues:

Selenium::WebDriver::Error::UnknownError:
unknown error: Chrome failed to start: crashed
 (unknown error: DevToolsActivePort file doesn't exist)
 (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)
 (Driver info: chromedriver=73.0.3683.68 (47787ec04b6e38e22703e856e101e840b65afe72),platform=Linux 4.4.0-17763-Microsoft x86_64)

My driver was previously setup and working using the following config:

require 'selenium-webdriver'
Capybara.register_driver :headless_chrome do |app|
	capabilities = Selenium::WebDriver::Remote::Capabilities.chrome(
		chromeOptions: { args: %w[headless disable-gpu] } # extras: no-sandbox disable-extensions
	)

	Capybara::Selenium::Driver.new(
		app,
		browser: :chrome,
		desired_capabilities: capabilities
	)
end
Capybara.javascript_driver = :headless_chrome
Capybara.current_driver = :headless_chrome

Thanks in advance!

from chromedriver-helper.

flavorjones avatar flavorjones commented on August 17, 2024

@hybridspyda Please open an issue with the webdrivers gem.

from chromedriver-helper.

flavorjones avatar flavorjones commented on August 17, 2024

CI pipelines have been deleted from https://ci.nokogiri.org/.

I'm about to archive this git repo, and so I'll ask you all to trust that this evening I will kick back with a beer as required in the punchlist above.

lando-wave

from chromedriver-helper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.