Not compatible with all connect middleware about union

[indexzero]

@unscene Not compatible in what way? Is there an error thrown? If so, can you paste the stack trace?

[unscene]

@indexzero sure updated main issue for you

[unscene]

It looks like in core.js somewhere between

break in node_modules/union/lib/core.js:24

and here

break in node_modules/flatiron/node_modules/director/lib/director/http/index.js:76

The response object no longer is of type http.ServerResponse, or at least a crippled version.

[indexzero]

Yes, I see. We need to pass-thru this method from http.ServerResponse

[unscene]

I upgraded to the latest version of connect (2.0.0) and that fixed my problem. However if you want to use the latest version (1.8.5) of connect on npm, any connect middleware that abuses _implicitHeader will cause union to DIAF. Passing through _implicitHeader in ResponseStream "works" but then the patch.js problem in connect reveals itself.

The only suggestion I have is maybe pass through all methods of http.ServerResponse, so these issue can be exposed by the faulty middleware.

[indexzero]

We should update the docs to specify the compatibility with only connect >= 2.0.0

[amelon]

there's still issue with connect session middleware and union:

-union: 0.1.7
-flatiron: 0.1.11
-connect: 2.0.0alpha1

As mentioned, connect patch ServerResponse prototype to support event "header". (connect/lib/patch.js)
On session middleware, connect expect the response parameter to be a http.ServerResponse and it listens to "header" event to write cookie header.
(line 221 on connect/lib/middleware/session.js)

    // set-cookie
    res.on('header', function(){
      if (!req.session) return;
      var cookie = req.session.cookie
        , proto = (req.headers['x-forwarded-proto'] || '').toLowerCase()
        , tls = req.connection.encrypted || (trustProxy && 'https' == proto)
        , secured = cookie.secure && tls;

      // browser-session cookies only set-cookie once
      if (null == cookie.expires && !sessionIsNew) return;

      // only send secure cookies via https
      if (cookie.secure && !secured) return debug('not secured');

      debug('set %s to %s', key, req.sessionID);
      res.setHeader('Set-Cookie', cookie.serialize(key, req.sessionID));
    });

As response object forwarded by union to connect is a ResponseStream object, "header" event is never emit.