Comments (4)
Sorry I just found out after filling this issue that this has already been reported in #1694, but it was closed in 2018 as "this is simply not implemented". As this function call is in the JS API docs since 1.0.0
I do consider this a bug.
from framework.
Hello,
This is not a bug, it just is/was never a feature to filter discussions by ID. The API docs aren't wrong either because depending on the model you're trying to find, the ID filter might be implemented in the backend, and if so, it would give you the right results.
Feel free to PR this feature however, the post model ID filter can be used as an example: https://github.com/flarum/framework/blob/0da069ba9fe0ba2c742998f5fc7a7cc94eeb239e/framework/core/src/Post/Filter/IdFilter.php - and if you do, don't forget an integration test ;) -
Gonna close as we are only keeping track of bugs here and features on the forum.
from framework.
Feel free to PR this feature however, the post model ID filter can be used as an example: https://github.com/flarum/framework/blob/0da069ba9fe0ba2c742998f5fc7a7cc94eeb239e/framework/core/src/Post/Filter/IdFilter.php - and if you do, don't forget an integration test ;) -
Thank you for the hint. I must admit that I searched how to add this filter but was kind of lost in all the different classes involved.
I will probably try to add this feature soon™.
from framework.
Maybe adding a comment in the JS API docs that warns about this filter being possibly not implemented depending on the Model could be more explicit? I suspect that other Models than Discussion's one are also affected by this issue.
from framework.
Related Issues (20)
- Enabling/Disabling extensions should clear the cache HOT 2
- Discord invite link is not valid HOT 3
- Cross-laravel application HTTP request 504 Gateway Time-out HOT 8
- `isDark` throws an error and the app crashes if a color is set to `NULL` in the database HOT 8
- Mentions fire xhr after completing the mentions element
- Undoing Hiding (ignoring) discussions HOT 4
- Package Manager error in Flarum 1.7.1
- fttb slow response time HOT 6
- fttb slow response time HOT 1
- flarum/flags should use pagination HOT 1
- [Package Manager] updating when using beta packages HOT 1
- Code syntax highlighting bug HOT 12
- Permission grid doesn't show all the tags
- Make use of improved color contrast for group badges
- Hardcoded "wrote" in flarum/bbcode
- flarum/phpstan still have not been released on packagist HOT 2
- [Core - JS] UserSecurityPage is not exported
- Opening discussions becomes extremely slow when loading a lot of discussions.
- Release v1.8
- New installation appears:flarum.ERROR: Less_Exception_Compiler: .tag-label is undefined HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from framework.