Comments (15)
I've worked on 2 applications built on L5, as with anything it's a rather tedious process of fixing everything when it breaks from a composer update. As of right now, Laravel 5 isn't even alpha, and package loading is currently being restructured, so I would strongly recommend you stick it out with L4 through January (there will be an accessible upgrade path afaik)
from framework.
Honestly, the whole upgrade path of laravel makes me surprised you guys chose it as the base.
from framework.
@mikedugan Alright, thanks, we'll postpone the upgrade till it's stable.
@aequasi From what I gather, the upgrade from L4 to L5 won't actually be that painful at all. It's just at this point, L5 is changing so much that upgrading early causes a lot of pain.
from framework.
@tobscure i meant the upgrade path in general. Laravel. BC breaks, undocumented changes, lack of community additions..... All kind of scary for a project like this
from framework.
No, don't upgrade, it's not ready yet.
from framework.
Suggest closing this thread to prevent it from turning into L5 thread :)
from framework.
Since L5 is finally out I'll start working on this.
from framework.
Thanks @yulianovdey. I have a few thoughts:
- We can ditch the laracasts/commander command bus and domain events for the native L5 one (which you've already mentioned :)
- I wonder if we should refactor the whole Api/Actions thing to be more "native"? Make use of controllers and middlewares and stuff? Haven't thought about this in detail, and I do like the current setup (it's a nice layer of decoupling from Laravel), but I'm open to suggestions.
- Will also need to work on the flarum/flarum repo and installation instructions. Specifically, workbench is gone.
Let me know if you have any questions.
from framework.
@tobscure I like the current setup, it helps enforce simple classes. I don't think there is any advantage to using controllers if you like the way it is now, unless making things more 'native' is worth the extra bit of familiarity new contributors will have.
As far as middleware, it may be a nice way to move your attemptLogin filter to its own class. I gotta look around more to see what else would make sense for it. Either way I'm assuming you want to keep as little as possible in flarum/flarum so we'll need a clean way to register any middleware out of the core. At least the default stuff doesn't even look like it's going to be needed since you're not using (cookie) sessions at all :).
from framework.
@yulianovdey It looks like we have to remove everything inside app/Kernel.php
from framework.
@yulianovdey OK, let's keep the current Api/Actions stuff :)
Don't worry too much about all of the auth stuff at the moment. I'm going to implement OAuth2 soon so it's gonna get a makeover. Will probably also make use of cookies somewhat (maybe).
from framework.
Hey @yulianovdey turns out I have been working quite heavily on the Laravel app — mainly auth stuff, and I'm refactoring API Actions so that it's easier to call them from within other routes. Will be pushing soon. Let me know how far along you are (if you've made a start) and I'm happy to help merge.
from framework.
@tobscure I haven't started yet, still working on something else. Looking forward to seeing your changes :).
from framework.
@yulianovdey No worries. The refactoring has become a bit of a mess and the next logical step is really to do the L5 upgrade. So I'll be making a start tomorrow!
from framework.
Great work with the upgrade!
from framework.
Related Issues (20)
- Missing Component Exports
- DispatchEventsTrait causes error when event does not have "actor" attribute due to PHP 8.2 deprecation HOT 4
- Setting permissions on mobile does not display correctly on mobile
- PostRepository::getIndexForNumber() walks 2 time the posts table to get offset HOT 6
- Code blocks are hard to read in dark mode HOT 2
- [1.x] `Conditional` extender instantiates the extenders array even when the conditional is false
- Support Invokable Classes in Console Extender's schedule method
- Akismet False Positives Triggered by Flag Removal
- Content max limit is incorrect HOT 2
- [2.x] `LogoutController` permits open redirects
- Height of Modals on Mobile Inconsistent
- fttb slow response time
- Invisible buttons when making primary color #ffffff
- Admin page's Save button won't reset if an error occurs HOT 1
- JSON:API Layer Refactor HOT 3
- Cryptograhpically Sign releases HOT 9
- [Pusher] New notifications count increment doesnt work
- SEO meta description doesn't take from site settings
- Advanced Maintenance HOT 1
- API Client breaks the forum if used in environment like Swoole and with extension that need some values from server params HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from framework.