Coder Social home page Coder Social logo

Comments (9)

auxesis avatar auxesis commented on August 17, 2024

👍

from omnibus-flapjack.

jessereynolds avatar jessereynolds commented on August 17, 2024

omnibus won't let me have ~ in the version string as it uses git to cache builds and tries to make a tag name including the ~, which don't work. the error:

git --git-dir=/var/cache/omnibus/cache/install_path/opt/flapjack \
  --work-tree=/opt/flapjack tag -f \
  "flapjack-1.0.0~rc3~20140727T125000-9b1e831-1-d21c5f83ca481acd784f15b0429044339e88d6b59918af056029f825766e8ee1"

fatal: 'flapjack-1.0.0~rc3~20140727T125000-9b1e831-1-d21c5f83ca481acd784f15b0429044339e88d6b59918af056029f825766e8ee1' 
  is not a valid tag name.

raw output:

      [Builder: flapjack] I | Build succeeded! (215.66244961s)
     [Software: flapjack] I | Caching build
                          I | $ git --git-dir=/var/cache/omnibus/cache/install_path/opt/flapjack --work-tree=/opt/flapjack add -A -f
                          I | $ git --git-dir=/var/cache/omnibus/cache/install_path/opt/flapjack --work-tree=/opt/flapjack commit -q -m "Backup of flapjack-1.0.0~rc3~20140727T125000-9b1e831-1-d21c5f83ca481acd784f15b0429044339e88d6b59918af056029f825766e8ee1"
                          I | $ git --git-dir=/var/cache/omnibus/cache/install_path/opt/flapjack --work-tree=/opt/flapjack tag -f "flapjack-1.0.0~rc3~20140727T125000-9b1e831-1-d21c5f83ca481acd784f15b0429044339e88d6b59918af056029f825766e8ee1"
/var/lib/gems/1.9.1/gems/mixlib-shellout-1.4.0/lib/mixlib/shellout.rb:257:in `invalid!': Expected process to exit with [0], but received '128' (Mixlib::ShellOut::ShellCommandFailed)
---- Begin output of git --git-dir=/var/cache/omnibus/cache/install_path/opt/flapjack --work-tree=/opt/flapjack tag -f "flapjack-1.0.0~rc3~20140727T125000-9b1e831-1-d21c5f83ca481acd784f15b0429044339e88d6b59918af056029f825766e8ee1" ----
STDOUT:
STDERR: fatal: 'flapjack-1.0.0~rc3~20140727T125000-9b1e831-1-d21c5f83ca481acd784f15b0429044339e88d6b59918af056029f825766e8ee1' is not a valid tag name.
---- End output of git --git-dir=/var/cache/omnibus/cache/install_path/opt/flapjack --work-tree=/opt/flapjack tag -f "flapjack-1.0.0~rc3~20140727T125000-9b1e831-1-d21c5f83ca481acd784f15b0429044339e88d6b59918af056029f825766e8ee1" ----
Ran git --git-dir=/var/cache/omnibus/cache/install_path/opt/flapjack --work-tree=/opt/flapjack tag -f "flapjack-1.0.0~rc3~20140727T125000-9b1e831-1-d21c5f83ca481acd784f15b0429044339e88d6b59918af056029f825766e8ee1" returned 128
    from /var/lib/gems/1.9.1/gems/mixlib-shellout-1.4.0/lib/mixlib/shellout.rb:244:in `error!'
    from /var/lib/gems/1.9.1/bundler/gems/omnibus-ruby-5ad405c915e4/lib/omnibus/util.rb:77:in `shellout!'
    from /var/lib/gems/1.9.1/bundler/gems/omnibus-ruby-5ad405c915e4/lib/omnibus/install_path_cache.rb:85:in `incremental'
    from /var/lib/gems/1.9.1/bundler/gems/omnibus-ruby-5ad405c915e4/lib/omnibus/software.rb:623:in `execute_build'
    from /var/lib/gems/1.9.1/bundler/gems/omnibus-ruby-5ad405c915e4/lib/omnibus/software.rb:451:in `build_me'
    from /var/lib/gems/1.9.1/bundler/gems/omnibus-ruby-5ad405c915e4/lib/omnibus/project.rb:95:in `block in build_me'
    from /var/lib/gems/1.9.1/bundler/gems/omnibus-ruby-5ad405c915e4/lib/omnibus/project.rb:94:in `each'
    from /var/lib/gems/1.9.1/bundler/gems/omnibus-ruby-5ad405c915e4/lib/omnibus/project.rb:94:in `build_me'
    from /var/lib/gems/1.9.1/bundler/gems/omnibus-ruby-5ad405c915e4/lib/omnibus/cli.rb:72:in `build'
    from /var/lib/gems/1.9.1/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
    from /var/lib/gems/1.9.1/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
    from /var/lib/gems/1.9.1/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
    from /var/lib/gems/1.9.1/bundler/gems/omnibus-ruby-5ad405c915e4/lib/omnibus/cli/base.rb:33:in `dispatch'
    from /var/lib/gems/1.9.1/bundler/gems/omnibus-ruby-5ad405c915e4/lib/omnibus/cli/deprecated.rb:128:in `dispatch'
    from /var/lib/gems/1.9.1/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
    from /var/lib/gems/1.9.1/bundler/gems/omnibus-ruby-5ad405c915e4/lib/omnibus/cli.rb:41:in `execute!'
    from /var/lib/gems/1.9.1/bundler/gems/omnibus-ruby-5ad405c915e4/bin/omnibus:11:in `<top (required)>'
    from bin/omnibus:16:in `load'
    from bin/omnibus:16:in `<main>'

from omnibus-flapjack.

 avatar commented on August 17, 2024

Hmm, I wonder if it's possible to escape the string being passed for the tag, and if omnibus would accept a patch for doing so?

from omnibus-flapjack.

jessereynolds avatar jessereynolds commented on August 17, 2024

Yeah i was thinking of doing something similar.

from omnibus-flapjack.

 avatar commented on August 17, 2024

git help check-ref-format doesn't seem to specify any allowed escaping. 😦

from omnibus-flapjack.

jessereynolds avatar jessereynolds commented on August 17, 2024

It might need to be a simple-minded character substitution, or removal

from omnibus-flapjack.

jessereynolds avatar jessereynolds commented on August 17, 2024

Issue #283 for this created in omnibus

from omnibus-flapjack.

jessereynolds avatar jessereynolds commented on August 17, 2024

reversed tilde works (∽) - U+223d - http://www.fileformat.info/info/unicode/char/223d/index.htm

jesse@heart-of-gold git $ git tag apricot~sausage
fatal: 'apricot~sausage' is not a valid tag name.
jesse@heart-of-gold git $ git tag apricot∽sausage

from omnibus-flapjack.

jessereynolds avatar jessereynolds commented on August 17, 2024

~ working now with current omnibus master.

deb created like so:

docker run --rm -i -t -e "FLAPJACK_BUILD_REF=6ba5794" \
  -e "FLAPJACK_PACKAGE_VERSION=1.0.0~rc3~20140729T222700-6ba5794-1" \
  flapjack/omnibus-ubuntu bash -c \
  "cd omnibus-flapjack ; \
  git pull ; \
  bundle install --binstubs ; \
  bin/omnibus build --log-level=info flapjack ; \
  bash"

deb installs like so:

vagrant@flapjack-test:~$ sudo dpkg -i /vagrant/flapjack_1.0.0~rc3~20140729T222700-6ba5794-1-1_amd64.deb
Selecting previously unselected package flapjack.
(Reading database ... 51095 files and directories currently installed.)
Unpacking flapjack (from .../flapjack_1.0.0~rc3~20140729T222700-6ba5794-1-1_amd64.deb) ...
Setting up flapjack (1.0.0~rc3~20140729T222700-6ba5794-1-1) ...
Creating /etc/flapjack/flapjack_config.yaml
Creating /etc/init.d/redis-flapjack
Creating /etc/init.d/flapjack
Creating /etc/init.d/flapjack-nagios-receiver
Creating /etc/init.d/flapper
Setting paths
Starting redis-flapjack
Starting redis-server: redis-server.
Starting flapjack
Flapjack starting...Daemon has started successfully
 done.
Thank you for installing flapjack!
Flapjack should now be running. Visit http://localhost:3080/
vagrant@flapjack-test:~$ ps aufx | grep flapjack
vagrant   1454  0.0  0.0  11676   944 pts/0    S+   22:53   0:00              \_ grep --color=auto flapjack
flapjack  1436  0.2  0.1  38144  1740 ?        Ssl  22:50   0:00 /opt/flapjack/embedded/bin/redis-server 127.0.0.1:6380
root      1449  0.2  7.4 189084 75580 ?        Sl   22:50   0:00 /opt/flapjack/embedded/bin/ruby /opt/flapjack/bin/flapjack server start

from omnibus-flapjack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.