Make package pushing optional? about omnibus-flapjack

[jessereynolds]

@someword - right, in 8b6744b I added the optional SKIP_S3_STORE environment variable. If you set it (to anything) then the push to S3 will be skipped. Is this good enough, do you think? I was wondering if this would still trip people up and perhaps the environment variable should have been the other way around (only try storing to S3 if the variable is set, eg FLAPJACK_STORE_TO_S3

Also, the version of flapjack to build now also needs to be set in FLAPJACK_BUILD_TAG (eg "0.8.4") and you don't need to update the version string in config/{software|projects}/flapjack.rb anymore. See https://github.com/flpjck/omnibus-flapjack#vagrant-based-virtualized-build-lab and https://github.com/flpjck/omnibus-flapjack#automatic-upload-to-s3

...It's a bit klutzy using environment variable so heavily around this stuff but the only way around it I can see is having a script in front of vagrant, but this seems worse. It'd be nice if you could set arbitrary variables for consumption in the Vagrantfile by passing them in the command line to vagrant, eg vagrant up -- skip-s3-store=true flapjack-build-tag=0.8.4 etc ... anyway, back to the subject at hand...

[jessereynolds]

Actually, the SKIP_S3_STORE implementation was not complete in the aforementioned commit. I should have fixed this in 56e0d91 - I will test this a bit later.

[jessereynolds]

With the new workflow this can be achieved by setting the following ENV var prior to running the build script:

export skip_package_upload=true