Comments (5)
getValue / hasFeature is pretty much exactly the same as doing flags[name]. These calls do not interact with the api and are synchronous.
The approach should still be as I mentioned, if we started to resolve a set of flags with these calls it would encourage not using these functions which allow for flag analytics and possibility for any other future features.
I will take a look at these calls as the type file suggests they do resolve with flags, however regardless of this, waiting for the promises to resolve and using flagsmith functions is still probably the way to go.
from flagsmith-js-client.
Could I ask what the usecase here is, @Nihir10dec? The idea is to use flagsmith calls such as getValue/hasFeature/getTrait or getState for ssr/isomorphic after the flags and traits have been retrieved (either after onChange or when these promises are resolved)
Iām not really sure what we would want to resolve with if anything. The main thing here is all the gets will at this point have new values.
from flagsmith-js-client.
So my use case is to get all the Flags at the point where I call the identify()
function, so that I retrieve all the flags according to the identified user.
As there are a lot of features and it's a large project where I'm using, calling each features getValue()
can be just redundant work.
Hence to retrieve all the flags at just once, I wanted the values returned from the promise.
from flagsmith-js-client.
Hey, @kyle-ssg Any thoughts or suggestions on this?
from flagsmith-js-client.
Considering the above, the types have been updated in 1.6.2 to indicate that getFlags etc do not resolve with flags
from flagsmith-js-client.
Related Issues (20)
- Flagsmith's `loadingState.error` is not respect actual error state HOT 11
- [Bug] - NextJS >= 13.0.0 SSR `useFlagsmith` state not matching the state that is passed to the provider. HOT 16
- flagsmith/react only works in React 18 HOT 3
- [Bug] - TypeError: Cannot read properties of null (reading 'getValue') HOT 5
- Flagsmith's 'useFlags' doesn't return actual cached flags when request failed HOT 2
- Rollup Name for react HOT 5
- Inconsistent license information HOT 2
- Caching with multiple instance doesn't work HOT 6
- Typing issue in react.tsx: 'flagsmith' is possibly 'null' HOT 3
- useFlags() race condition HOT 8
- Different environments not working HOT 5
- Localstorage cache is not being wiped out in some edge cases HOT 3
- Support `getValue` fallback without `json` flag HOT 2
- useFlags not updating values in react18/Nextjs App Router
- 3.23.0 seems to have broken something HOT 4
- Intermittent Flakiness in Feature Flags on Safari/MacOS HOT 2
- Flags are null when the cacheFlags option is true HOT 3
- Typescript compiler errror `Cannot find name 'F'.` when compiling flagsmith in Angular project HOT 3
- Bundle ES(flagsmith-es) and combine with standard CJS module (flagsmith)
- Identifier/trait confusion when using `cacheOptions: { skipAPI: true } ` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flagsmith-js-client.