Add type definitions for the client about flagsmith-js-client

[kyle-ssg]

Added in bullet-train-client and react-native-bullet-train 0.2.3, enjoy!

If you find any type issues, comment here but think everything is covered.

[crutchcorn]

Also, instead of having a webpack fix, what I might suggest is doing something like:

shared_types.ts:

export interface Test {
    example: string;
}

export interface Other {
   oneMore: number;
}

Then, in each of the instances you need those types:

declare module 'bullet-train-client' {
    export * from './shared_types;
}

That way, you can have a single source-of-truth without having to deal with webpack copy messiness. Feel free to ping me about TS-related issues for this project in the future :) I'd love to be of assistance!

[crutchcorn]

I'm getting a build failure when using TS as-of version 0.2.3 in Angular.

7016: Could not find a declaration file for module 'bullet-train-client'. '/Users/crutchcorn/git/Coopervision/CVExtreme/node_modules/bullet-train-client/index.js' implicitly has an 'any' type.
  Try `npm install @types/bullet-train-client` if it exists or add a new declaration (.d.ts) file containing `declare module 'bullet-train-client';`

2 import bulletTrain from 'bullet-train-client';
                          ~~~~~~~~~~~~~~~~~~~~~

However, renaming the bullet-train-client.d.ts file to index.d.ts in node_modules fixes this for me

[crutchcorn]

Another fix for this would be to add the following to package.json:

  "types": "./bullet-train-client.d.ts"

However, I think that the isomorphic import would also break. I would suggest moving both d.ts files into the same index.d.ts file (since they're namespaced, it should work properly) and then adding it to the types field in package.json

I can make a PR if that'd help

[kyle-ssg]

Ah strange, but I totally see what you mean about combining. I think ideally I'd look to also have some automated webpack approach for this since react-native, isomorphic AND the general lib have the same types.

Hmm, I didn't think naming as index.d.ts was a requirement, I'm sure other modules don't do this.

If you're offering to do that quickly though @crutchcorn that would definitely be appreciated!

[crutchcorn]

Yup! It's somewhat blocking stuff at work, so let me see if I can't just fix this issue quickly :) Forking now!

[kyle-ssg]

Thanks, apologies about that! It's strange because running the client locally command clicking jumps to the .d.ts instead of the lib code which signifies it's working.

Regardless, I'll keep an eye out for this, do some quick sanity checks and publish a version as soon as I see it!

[crutchcorn]

Right! Very weird, the differences between the TS language provider (for IDEs) and the compiler 🤷‍♂️

Either way #31 has been opened to help resolve this

[kyle-ssg]

Version @0.2.4 released, thank you again!

Will close for now, but reopen if you come across anything TS related.