SyntaxError when importing in browser via ES6 modules about flagsmith-js-client

[bradberger]

Fixed! Thanks so much!

[kyle-ssg]

Global removed in [email protected]. The es version numbers will now always be in sync with flagsmith for every release. Let me know if that's all sorted your end @bradberger ?

[kyle-ssg]

Hmm I see. I think it's quite common for modules to have separate bundles for es6, e.g. lodash-es.

Let me know but it seems the solution could be to have flagsmith/es and flagsmith/react-es, also these bundles could look to avoid using window.flagsmith. Does that sound suitable @bradberger ?

[bradberger]

@kyle-ssg That'd be perfect!

[kyle-ssg]

Having said this, It's a bit strange since the nextjs/react examples import flagsmith fine https://github.com/Flagsmith/flagsmith-js-client/blob/main/examples/react/src/index.tsx. Is there a valid reason for this do you think?

[bradberger]

Hmm good point. We've used it in React, too, without issue. I'm wondering if React compiles to something less than ES6 for compatibility. Maybe we need to do that too. I can check into that, it might be a possible solution. But all the same ES6 support would be great if it's possible.

[kyle-ssg]

Yeah I bet there's some clever webpack config for create-react-app / nextjs in general. Looking into this now 👍

[kyle-ssg]

Could you try npm i flagsmith-es as a replacement to flagsmith @bradberger ?

[bradberger]

@kyle-ssg That did the trick! It still appears to populate the window.flagsmith variable, but importing createFlagsmithInstance() works perfectly and the global instance isn't our instance.

[kyle-ssg]

Ok let me just sort the global!