Coder Social home page Coder Social logo

Comments (3)

fjosw avatar fjosw commented on May 12, 2024

Yes, I implemented this additional check to be sure that the data is not corrupted. I believe all entries of a correlator should be defined on the same set of configurations in all practical scenarios (although that is not strictly necessary for the correct error propagation). Do you have any use cases in which you would want to initialize such a correlator?

Also the json output for correlators strictly assumes that all non None entries are defined on the same set of configurations. Otherwise the reassembling into a 3D array would not work. That is also why I had to implement the function _nan_Obs_like (https://github.com/fjosw/pyerrors/blob/develop/pyerrors/input/json.py#L164).

from pyerrors.

JanNeuendorf avatar JanNeuendorf commented on May 12, 2024

I could imagine someone measuring more configurations for one smearing level and still wanting to use the GEVP methods. Theoretically the new Obs can know, what configurations it was measured on (?) and be compatible. But i would not need this and if it is hard to implement, we can leave it as it is.

from pyerrors.

fjosw avatar fjosw commented on May 12, 2024

I propose to leave the Corr.__init__ method as it is for now. If such a special case is needed in the future we can revisit this issue.

from pyerrors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.