Comments (3)
Yes, I implemented this additional check to be sure that the data is not corrupted. I believe all entries of a correlator should be defined on the same set of configurations in all practical scenarios (although that is not strictly necessary for the correct error propagation). Do you have any use cases in which you would want to initialize such a correlator?
Also the json output for correlators strictly assumes that all non None
entries are defined on the same set of configurations. Otherwise the reassembling into a 3D array would not work. That is also why I had to implement the function _nan_Obs_like
(https://github.com/fjosw/pyerrors/blob/develop/pyerrors/input/json.py#L164).
from pyerrors.
I could imagine someone measuring more configurations for one smearing level and still wanting to use the GEVP methods. Theoretically the new Obs can know, what configurations it was measured on (?) and be compatible. But i would not need this and if it is hard to implement, we can leave it as it is.
from pyerrors.
I propose to leave the Corr.__init__
method as it is for now. If such a special case is needed in the future we can revisit this issue.
from pyerrors.
Related Issues (20)
- projected not working for correlators with "None" elements HOT 1
- corr.m_eff() does not check for division by zero HOT 6
- Dublication in input.dobs.read_dobs HOT 1
- Nested loop with same variable in input.dobs
- numerical differentiation in derived_obs not working HOT 5
- Automatic windowing method fails for gapped and irregular chains HOT 4
- Issues with _filter_zeroes and Corr HOT 4
- Exception when applying .symmetric() to Corr containing None HOT 1
- Gamma_method() is broken for Obs that are NaN
- Multi-dimensional fits
- Bug coming from difference in search methods in sfcf inputs HOT 2
- `Corr.show()` draws prange in same color as error bars. HOT 1
- No dobs-related functions from the input submodule can be used HOT 1
- GEVP eigenvectors with errors HOT 7
- Warning in pandas tests
- Numpy 1.25 breaks a few linalg functions HOT 3
- Failing python 3.12 pytest workflow
- Duplicate data cause `gamma_method()` to fail with an unhelpful message HOT 3
- plot_history unexpected behaviour for gapped idl HOT 2
- read_hd5 in pyerrors 2.9.0 not fully backwards compatible to <=2.8.2 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyerrors.