Comments (10)
Can you provide us with a plunker that fails like this?
from angular-social-links.
here is http://plnkr.co/edit/9IahkgyAE1ru5bJyV1wP
type anything on textbox if its image url then it has update media attribute for pinterest
or twitter status message.
Reason for showing this as when data coming from ajax and then we try bind with media attribute or description things doesn't looks working.
let me know if you have some solution for it.
from angular-social-links.
@mrunwal Thanks for the example - try v0.0.12 !
from angular-social-links.
I have tried same code but it looks its still the same.
from angular-social-links.
Updated code works in plunkr for "http://lorempixel.com/1200/630/"
http://plnkr.co/edit/NlnvU8D2VeY40wB846p4
I'm guessing that you don't want to have the user click on the share button before your media url has been retrieved from ajax. The share buttons will update the url when clicked. We want to keep the directives clean and light-weight without unnecessary watches.
Perhaps you can consider hiding the share buttons until you are ready to share - we have done this on a project without issue.
from angular-social-links.
Thank for efforts but my logic was different. eg. when angular load the products using ajax then product attribute variables updates after few mili-seconds and then once its loaded that product variable's image should be used for pinterest. but right now when Ajax gots response and when its time to see the url...media fields is gets blank...
Anyway...thanks for help
from angular-social-links.
When clicking on the pinterest icon on your page the media image is working. The url on the link has a blank media string because of the variable being blank at the linking time of the directive. The correct url is opened in the window.
If you can provide a use-case for the href live binding and a pull request we'd be happy to merge if the code stays clean.
Closing this issue for now.
from angular-social-links.
Thanks it work as per your words... live binding now working. though status url does not show but when popup appears its functional.
from angular-social-links.
Seems like this would be more effective if you got the URL when you do the click, instead of filling the href when the directive loads.
I am using this on a page template where the route changes and the share template is static in the sidebar and just keeps whatever the first URL was when the page loaded.
from angular-social-links.
Thanks for building this! Great clean code. I, too am looking to live bind my custom URL.
I second @lommaj and his views on the subject. I am working on a playlist application, and want to be able to share each song when the url changes. Right now it is just stuck on the song that first loads.
from angular-social-links.
Related Issues (10)
- Number of shares of a url HOT 3
- getCurrentUrl call invalid HOT 2
- Update npm registry with the latest version of the package HOT 3
- Facebook sharer.php no longer supports custom parameters
- Twitter url is not recalculated once she is defined
- webpack build HOT 4
- npm module HOT 3
- Fails to install through bower with Angular 1.4 HOT 5
- observe customUrl
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-social-links.