Hide dock icon in OSX about gpgsync

[micahflee]

I think this is a PyInstaller bug. I opened an upstream issue: pyinstaller/pyinstaller#1917

[samuelcouch]

I spent some time exploring using py2app instead of pyinstaller, however I kept getting a weird error
AttributeError: 'ModuleGraph' object has no attribute 'scan_code' which seems to be a known issue from googling around. The only solution I found was to actually change the function calls within the py2app package, which seems hacky at best.

Was curious if you experienced this when you were using it?

[micahflee]

I've run into various issues in the past with py2app, but I don't remember ever hitting that one.

Note that I first tried using py2app for this project, but switched to pyinstaller because of #2. Here's the commit where I switched everything: 19917f7 maybe comparing your setup.py with what was removed in that commit could be helpful.

[micahflee]

Another thing to keep in mind is that each method of creating an app bundle ends up putting resources in its own place. Switching to py2app (or anything else) will require refactoring the common.get_resource_path method, which currently works for pyinstaller: https://github.com/firstlookmedia/pgpsync/blob/master/pgpsync/common.py#L30

[samuelcouch]

I spent time investigating this quite a bit yesterday and today -- no luck. I tried reimplementing py2app, and I think some of the issues you mentioned were coming up, will need to look in to this more. I also looked at the Pyinstaller source to try and find a solution. I opened a new issue on the Pyinstaller repo pyinstaller/pyinstaller#2075 hoping it catches some eyes.

Do you think it's reasonable to push this off to a later milestone? My reasoning is that, recognizing that the dock icon is annoying, it's not the end of the world as far as functionality. If someone closes the app, it'll at least sync once the next time they restart their computer. While not ideal, it could be ok for now. Any thoughts on this?

[micahflee]

Hopefully pyinstaller devs will respond to your issue! And yeah, I think it's reasonable to push this bug onto a later issue since this bug is so gnarly. I'll set the milestone to 0.1.1 for now.

[micahflee]

It looked like someone found a solution to this issue in pyinstaller/pyinstaller#1917 but it appears that their solution actually didn't work. I tried manually compiling @Tristan79's branch of PyInstaller and using it to build GPG Sync, but unfortunately no luck.

Because of that, I think the solution might take a bit longer to come up with. I'm going to remove the 0.1.1 milestone from this issue, because I feel like we should make a release sooner in order to fix #10.

It does work, i spend a couple of hours scratching my head my it didn't work... on comicstreamer and it does on ibrew, now days later I realized i forgot to add the right plist... think adding

https://github.com/Tristan79/iBrew/blob/master/source/distro/mac/Info.plist#L5
and
https://github.com/Tristan79/iBrew/blob/master/source/distro/mac/Info.plist#L23
was the final trick to make it work...

see:
pyinstaller/pyinstaller#1917 (comment)

[micahflee]

There's a lot of progress happening recently in the upstream bug. Hopefully I can make the 0.2.0 build with a version of PyInstaller that's fixed, even if I need to run PyInstaller from a source tree with manual PRs merged into it: pyinstaller/pyinstaller#1917