Adding new settings option breaks app with an existing settings file about gpgsync

[micahflee]

Good catch. There are a few ways to handle this.

We can start versioning the settings file and writing migrations each time we make a change. E.g. if someone is running 0.1.0 and suddenly upgrades to 0.5.6 or whatever and the settings file is way different, it would load the 0.1.0 settings file and pass the object through a series of migrations, then finally save the 0.5.6 settings file.

Or we can do it the easier way and simply set a setting to its default value if it doesn't exist in the settings file already. Since this is such a simple project, that option would probably be fine. The problem would arise if we decide to change how an existing setting work (change it's type, etc). We just have to be careful not to make settings changes that will cause this to break down in the future.

[samuelcouch]

I implemented the 2nd option for now. I like the idea of creating migrations, but also think it may be overkill for such a simple app. The saving grace is that it is so simple and in the future we could easily switch our approach if we ever introduced any breaking changes to the settings.

[micahflee]

💯 agree