setFirmwareVersion leaks memory about arduino

[soundanalogous]

Good find. The unit tests are already proving to be useful :)

[mmurdoch]

I'm a bit stuck as to what to do with this. I'd like to provide a fix at the same time as the test (so that when the test is run it passes) but to do so I'd have to create a pull request to the unit tests branch (since we don't have tests on dev). Should I do this as two separate commits in a pull request to the unit tests branch and assume that the fix commit will be applied by someone else to dev? Alternatively I could create two pull requests, one with the test and fix commit to the unit test branch and another with just the fix to dev?

[soundanalogous]

Yeah I see how that could be annoying. I'll merge unit-tests into dev.

[soundanalogous]

I merged unit-tests into dev. If you have new work in your unit-tests branch, just merge in upstream dev and then submit a pull request to merge your branch of unit-tests into dev.

[mmurdoch]

I'm going to add memory leak checking to ArduinoUnit so I don't have any new work in my unit-tests branch - I'll rewrite the above test before creating a pull request.

Just to clarify, are you saying from now on push all unit tests (and fixes) directly to dev and create pull requests from there?

[soundanalogous]

Yeah since it's making it easier to detect and fix bugs. Will also be helpful in adding new features.

[mmurdoch]

Great, thanks!

[soundanalogous]

fixed in dev branch