Coder Social home page Coder Social logo

Comments (4)

t-woerner avatar t-woerner commented on May 18, 2024

firewall-cmd is only returning "Success" if the command succeeded. Here are some examples:

# firewall-cmd --permanent --zone=trusted --add-source=1.2.3.4
success
# firewall-cmd --permanent --zone=trusted --add-source=1.2.3.4
Warning: ALREADY_ENABLED: 1.2.3.4
# firewall-cmd --permanent --zone=trusted --remove-source=1.2.3.4
success
# firewall-cmd --permanent --zone=trusted --remove-source=1.2.3.4
Warning: NOT_ENABLED: 1.2.3.4

I just noticed that the return value is not correct in the warning case. I will fix this.

from firewalld.

MikeParkin avatar MikeParkin commented on May 18, 2024

Thanks for the quick response! What version was this functionality added?

[root@localhost vagrant]# /bin/firewall-cmd --permanent --zone=trusted --add-source=8.8.8.8
success
[root@localhost vagrant]# /bin/firewall-cmd --permanent --zone=trusted --add-source=8.8.8.8
success
[root@localhost vagrant]# /bin/firewall-cmd --version
0.3.9

I'm using 0.3.9 which was stock from Centos7 which doesn't seem to have the same behaviour.

from firewalld.

t-woerner avatar t-woerner commented on May 18, 2024

That has been added with 0.3.12.

from firewalld.

t-woerner avatar t-woerner commented on May 18, 2024

You will get this with the rebase to 0.4.3.

from firewalld.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.