Coder Social home page Coder Social logo

Comments (8)

andreasgrafen avatar andreasgrafen commented on May 16, 2024 2

It's fixed now. I've added a task to the gulp file in order to copy over the themes.json from / into /docs when the project is built. Since this prevents from changes being deployed immediately on change this also acts as another safety switch in case anything is wrong with the themes file.

from firefoxcss-store.github.io.

andreasgrafen avatar andreasgrafen commented on May 16, 2024 1

Yeah, that sounds like a plan! Let's hear what @Neikon thinks about this. c:

I'd suggest that we wait for the current pull requests to be resolved and then just change the gulp config real quick to automatically build into the /docs folder. I'd offer myself to clean up the repo then as well. :D

from firefoxcss-store.github.io.

BeyondMagic avatar BeyondMagic commented on May 16, 2024

Yeah, I think we can change it to docs, but, I don't see we using it a lot, it is quite a simple project right now, but maybe we can handle common bugs of themes, FAQ and those type of things there.

from firefoxcss-store.github.io.

andreasgrafen avatar andreasgrafen commented on May 16, 2024

Oh, no. I might have explained this poorly.

Currently the frontend serves right from the main directory (/root) but GitHub Pages allows users to alternatively serve from a subfolder (/docs). More common names would be public or dist, I think.
This way we wouldn't have the assets folder, robots.txt, index.html and all that in the main directory but rather in a subfolder. I think that would make everything look and feel a little bit more organised.

from firefoxcss-store.github.io.

BeyondMagic avatar BeyondMagic commented on May 16, 2024

Ah, 😓. Yes, let's do that, it's better than putting all those files in the root, also, we have a file called README.txt, I think we can delete it since the project is not using the Multiverse HTML5 template anymore.

But about the wiki, we can consider adding one if we need a FAQ.

from firefoxcss-store.github.io.

Neikon avatar Neikon commented on May 16, 2024

of course, yes. but as you say, let's first resolve the pull requests we have open.

from firefoxcss-store.github.io.

andreasgrafen avatar andreasgrafen commented on May 16, 2024

Since everything seems to be rresolved forr now I went ahead and changed the build folder.
Gulp now automatically builds into /docs and everything is served from there. ^—^

from firefoxcss-store.github.io.

andreasgrafen avatar andreasgrafen commented on May 16, 2024

Update: Appaently GitHub doesn't allow for anything outside the /docs folder to ba addressed.
I've just copied the themes.json over for now to fix this. Another way would be to hard link the URL but I dislike the idea. I'll take a look at a possible fix later.

from firefoxcss-store.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.