Coder Social home page Coder Social logo

Comments (2)

julienw avatar julienw commented on May 22, 2024

The goal is to survive a browser restart without losing your state, even if you haven't shared the profile publicly.

After sharing, should we delete the local data after changing the URL ?

Wait for symbolication to complete or no?

Actually, same question for public sharing :)

How to generate the ID?

Use a UUID ?

from profiler.

mstange avatar mstange commented on May 22, 2024

The goal is to survive a browser restart without losing your state, even if you haven't shared the profile publicly.

After sharing, should we delete the local data after changing the URL ?

I'd say yes.

Wait for symbolication to complete or no?

Actually, same question for public sharing :)

I'd say let's put it into the local database even during symbolication, and regularly update it until symbolication is done.
We can rate-limit the update based on time, and maybe even additionally use requestIdleCallback.

How to generate the ID?

Use a UUID ?

Or a sha1 of a UUID? :)

Either way sounds good as long as we don't suddenly start putting dashes or curly braces into the URL. And the ID should be independent of symbolication because we want the following scenario to work:

  1. Collect the profile
  2. Apply some kind of filter
  3. Wait for symbolication to finish
  4. Click back to clear the filter
  5. Restart the browser
    If symbolication changed the URL, then the URL that you'd go back to would be invalid, and on restart we wouldn't be able to load the right profile for it.

from profiler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.