Comments (2)
I'd rather not because we'd have to pull all of it in when we merge to devtools. If we want to look into this we should bring it up with the whole team. While we are operating as a separate project technically, as you know we're still heavily tied to whatever gecko-dev/devtools provides.
The other reason is that the utility will be reduced a lot when we switch to immutable.js, which I'm very convinced we need to do. We won't be able to use it with immutable.js, and is why things like transducers are better (they aren't tied down to the data structure like lodash is).
The current code was focusing on shipping (which may or may not be a bad thing). There are certainly places that need to be cleaned up and we will do that. I don't think we need lodash for that, personally. Much of the utility we would get will be provided by immutable.js' API.
I think we should put our efforts into migrating to immutable.js first and just augmenting any util functions we need.
from debugger.
Thanks, that makes a lot of sense. I agree, that this decision would be a team decision. Also, after reviewing today, I think we can clean up our code with a couple small utility functions. See my recent PR for a couple examples of groupBy
and values
.
Lastly, looking forward to seeing how Immutable.js and re-select helps us. That seems more inline with our redux state architecture.
from debugger.
Related Issues (20)
- [SourceTree] Can't copy event function source
- [Theme] TypeScript had black characters with dark theme HOT 5
- quote differences in the source and the event flag excerpt HOT 1
- Frozen debugger after breakpoint activation on remote debugging. HOT 6
- [Docs] More inclusive language in the documentation HOT 2
- yarn start no result: waiting for localhost .. HOT 1
- Call stack highlightling changes the links and names (through prettify) HOT 1
- Clearly state that the debugger's development now happens elsewhere HOT 2
- Source Maps not when using debugger with npm start HOT 1
- DOM "Break on > Attribute Modification" does not trigger when node is set to `display: none` HOT 1
- backslash and escape sequence HOT 1
- Debug
- Multi row strings make the debugger lines jump up and down HOT 5
- cheap-module-source-map does not show source maps. HOT 3
- Variables in debugging are unreadable HOT 1
- No hover popup on variable HOT 9
- Option to ignore scripts from addons
- Cant access this context after promise return HOT 1
- Option to save scripts automatically and execution blocks
- Webpack not working in Firefox 86 Developer Edition HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from debugger.