Comments (2)
Thanks for taking the initiative to help us with our documentation. I have a few comments, both about mechanism and content.
The mechanism for making contributions on GitHub is to fork our repository, and make a branch in your fork with your proposed changes. You then make a pull request to suggest we adopt those changes.
The primary way to contribute examples is by writing what we call demos. These are restructured text files in subfolders of the demos
folder in our source tree. They are converted into python files during the documentation building process. The result is a demo page on the website accompanied by a runable python script. You can see these demos on the documentation page. Instructions on building the documentation are on the download page.
Now, in terms of content, each demo should be showing some significant new feature of Firedrake so that users can refer to the demos to see how to do things. Of the Python files in your zip archive, the steady state heat equation seems to me to be materially identical to our existing Poisson tutorial notebook. The other two files seem to primarily introduce timestepping and vtk output. These are covered in our Burgers equation demo. The Burgers equation tutorial notebook takes this a bit further to show how to timestep more efficiently, and how to visualise timestepping using matplotlib.
Right now, it's not quite clear to me what additional information a user would draw from these examples, but my perspective is definitely not that of a typical user so I would really like to hear where our offering has gaps. PRs to fill them are even more welcome.
from firedrake.
Thank you for your feedback! Regarding your concerns about the additional information a user could possibly draw from these examples, compared to existing demos, I agree that there aren't any additional gaps being filled here, so perhaps these are not ideal to merge into the main repository. This was more a personal project of mine pertaining to a class, so I think it is acceptable for these to just remain separated, where anyone who is interested perhaps can stumble on this issue.
from firedrake.
Related Issues (20)
- INSTALL: Script fails at PETSc while downloading HWLOC HOT 13
- running error for Marmousi model HOT 2
- BUG: Solving the Stokes equations defined with TrialFunction returns an error HOT 1
- BUG: Greater error than expected in quadrilateral GLL elements HOT 4
- Compute norm of assembled derivative HOT 5
- "Too many indices for sum factorisation!" for calculating radius on extruded CubedSphereMesh. HOT 1
- INSTALL: ImportError when running firedrake-update on Linux HOT 2
- INSTALL: Linux (Ubuntu 22.04.4 LTS) HOT 12
- Tests for `to_petsc_local_numbering`
- BUG: firedrake-install is now failing with --petsc-int-type=int64 HOT 3
- Buckling problem HOT 2
- Flake8 for demos HOT 2
- Zenodo release
- Labelling of Internal Facets in Mesh Generated with Netgen HOT 3
- Zenodo release request
- Error on interpolation using --petsc-int-type int64 HOT 1
- BUG: Adjoint inconsistency with self-assignment via projection HOT 1
- BUG: Many tests fail with 64-bit indices
- Zenodo release please. HOT 1
- BUG: mesh.locate_cell not returning what is expected for points outside the mesh (--petsc-int-type=int64) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from firedrake.