Coder Social home page Coder Social logo

Comments (8)

kynan avatar kynan commented on July 25, 2024

I can reproduce that issue and looking at the wrapper code we generate for the interior facet integral I strongly suspect it's a firedrake bug. In fact looking through our existing test cases it seems (interior) facet integrals on vector function spaces are untested and therefore broken.

from firedrake.

wence- avatar wence- commented on July 25, 2024

I think this is caused by #165.

from firedrake.

dorugeber avatar dorugeber commented on July 25, 2024

Facet integrals won't support VFS for quite a while. Use a proper space, like BDM ;-)

from firedrake.

dorugeber avatar dorugeber commented on July 25, 2024

@ctjacobs do you still get this error?

I cannot reproduce this; it was probably 'fixed' by a combination of
OP2/PyOP2#319
https://bitbucket.org/mapdes/ffc/pull-request/17/fix-problems-with-existing-facet-integral
https://bitbucket.org/mapdes/ffc/pull-request/21/fix-ir-for-interior-facets

Note that you want n = FacetNormal(mesh) instead of n = FacetNormal(mesh.ufl_cell()).

from firedrake.

dorugeber avatar dorugeber commented on July 25, 2024

(I expect that the calculation is still wrong, though)

from firedrake.

wence- avatar wence- commented on July 25, 2024

There will now, hopefully, not be a NaN error. But the calculation will still be wrong because we haven't fixed interior facet integrals on vector function spaces yet. That's still #165.

from firedrake.

ctjacobs avatar ctjacobs commented on July 25, 2024

The NaN issue has indeed been fixed.

from firedrake.

dorugeber avatar dorugeber commented on July 25, 2024

What remains is a duplicate of #165, so I will close.

from firedrake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.