Comments (20)
I'm going to try to check this this week.
EDIT: Finally I will be able to check this next week: September 23-29
from flutterfire.
I've pushed a PR with the fix, can you try? You just need to point to the PR version?
firebase_dynamic_links:
git:
url: https://github.com/mrmilu/flutterfire.git
path: packages/firebase_dynamic_links
ref: firebase_dynamic_links-0.5.0+4
from flutterfire.
I've pushed a PR with the fix, can you try? You just need to point to the PR version?
firebase_dynamic_links: git: url: https://github.com/mrmilu/flutterfire.git path: packages/firebase_dynamic_links ref: firebase_dynamic_links-0.5.0+4
I don't know what @dhanrajvermaRepo means with "when app is in background" because, in order to open a Dynamic link from somewhere else, your app needs to be in background for sure, so...
Anyway, it is not working at all on iOS. App is being called and opened just fine, but the listener is not being called...
And not, @jherencia, your fix is not working, at leas not for me...
So I opened another issue #262
from flutterfire.
@quetool
As you pointed in the other issue (#262) you are using a custom domain, and when you configured correctly the Info.plist file, everything worked.
Does that mean that the my PR worked for you?
from flutterfire.
@jherencia sorry, I didn't notice you were talking about default domains... I didn't try again your PR after I solved my issue like I said in in #262
So, we need to wait for @dhanrajvermaRepo to answer that...
from flutterfire.
So you were using the latest official version (0.5.0+3) not the PR when it worked, right?
from flutterfire.
That's right
from flutterfire.
Managed to get it working, though it's still subscribing to onLink
multiple times, because I can't dispose the listener upon unmount. Would be good to get the listener back from channel.
Also note that
Navigator.pushNamed(context, deepLink.path);
needs to be a child of MaterialApp
to work.
from flutterfire.
I've pushed a PR with the fix, can you try? You just need to point to the PR version?
firebase_dynamic_links: git: url: https://github.com/mrmilu/flutterfire.git path: packages/firebase_dynamic_links ref: firebase_dynamic_links-0.5.0+4
I'll test my App on 8 October and let you know whether it is working or not.
Thank you
from flutterfire.
I've pushed a PR with the fix, can you try? You just need to point to the PR version?
firebase_dynamic_links: git: url: https://github.com/mrmilu/flutterfire.git path: packages/firebase_dynamic_links ref: firebase_dynamic_links-0.5.0+4
Hi, I have tested my app with this PR. It is working when app is in background. When app is in killed state it navigates to appropriate screen but returns to my root widget within a micro/millisecond. It is so fast that it seems it directly opens my root widget (root screen ie login screen). I have is used toast to debug this issue as in killed state i can not debug it.
Android working fine in all cases.
from flutterfire.
Can you post some example code to reproduce this?
from flutterfire.
Can you post some example code to reproduce this?
I am sorry.
PR is working fine in both android and iOS. There was a bug in my code.
Thank you very much.
from flutterfire.
Great to hear, thank you!
from flutterfire.
Great to hear, thank you!
But one thing i forgot to mention is that in every state(Active/background, killed) onLink method's onSuccess callback is called on iOS. But in android on Active/background state onLink method's onSuccess is called and in killed state getInitial link returns deepLink.
May I release my App with this PR?
from flutterfire.
@jherencia I can confirm your PR fix the problem on iOS when app is in "killed state"
from flutterfire.
Great to hear, thank you!
why onError callback of onLink method is not called when we do not come by link in iOS?
getInitialLink always returns null in iOS.
from flutterfire.
Because is not an error.
onError is called when we clicked on a dynamic link and something fails (for example, a network call to Firebase API to resolve the short link)
from flutterfire.
@jherencia Can I release my App with this PR?
from flutterfire.
Well, I cannot guarantee anything about this, it's a PR which has to pass a review and a process which can end up in the repo or not.
I wouldn't trust my repo because I can change things in the future without notice.
It's your call to clone it and freeze the version so you can rely on your own repo or wait or whatever you think is the best for your project.
from flutterfire.
Closing - looks like the problem is now fixed. Please create a new issue if the problem still persists as this one has generated a lot of noise from users posting stack traces without formatting.
from flutterfire.
Related Issues (20)
- [firebase_crashlytics]: Flutter App Crashes on Newer Devices After Submission to Google Play HOT 1
- [firebase_core]: <issue in android> HOT 1
- signInWithRedirect is of void type, but is stated as returning UserCredentials in the docs HOT 1
- FirebaseCoreHostApi.initializeCore HOT 2
- Domain=FIRAuthErrorDomain Code=17999 with firebase auth HOT 2
- [FirebaseAuth]: Unhandled Exception: type 'List<Object?>' is not a subtype of type 'PigeonUserInfo' in type cast HOT 1
- firebase_auth: Error: Type 'IdTokenResult' not found. HOT 3
- [firebase_crashlytics]: java.io.IOException: Breakpad symbol generation failed (exit=1) by GitHub Actions HOT 5
- [firebase_hosting] Wasm is not used in Flutter Web App HOT 2
- [firebase_messaging]: background proccesing messaging not working 17.5.1 ios HOT 1
- [cloud_firestore]: ListenSource.cache seems to be ignored for document snapshots HOT 1
- [firebase_core]: <runTransaction throws an exception on Windows.>
- [firebase_database]: Issue on web debug mode when listening to multiple onValue streams on the same path HOT 1
- [firebase_auth]: Flutter web release mode got this error when performing `signInWithPopup` : "UnImplementedError: signInWithPopup is only supported on web based platforms Flutter" HOT 1
- [firebase_messaging]: Scheduled notifications in Recipient time zone on iOS HOT 2
- [Database/unavailable] Service unavailable on Android after update - Possible impact of multiple database support? HOT 3
- Firebase phone auth returns: An internal error has occurred. [ Error code:39 ] HOT 4
- [AppCheck]: Pub get fails after share_plus releases new versions HOT 2
- [firebase_analytics]: Error on launchUrl of url_launcher HOT 1
- [web]: Dependency issue with other package using `web: ^1.0.0` HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flutterfire.