Padding is nonzero about go-diameter

[jaroszan]

Can you please specify AVP type for which it is happening?

[taseppa]

I noticed the problem with Session-Id (UTF8String) and Origin-Host (DiameterIdentity) at least.

[jaroszan]

I can see it as well, however for nested AVPs UTF8String is padded correctly in my case.

[jaroszan]

Curiously when I run examples scripts (client/server) all AVPs are padded correctly.

[jaroszan]

It seems that issue is reproducible when client's bench option is set to true in examples/client/client.go. AVPs in ACR/ACA are padded incorrectly.

[jaroszan]

It looks that it is somehow dependent on the order in which AVPs are added to a message.

[fiorix]

This is not a fix for it, still trying to reproduce. I believe this bug was recently introduced by one of the changes in the encoder.

[fiorix]

Can someone send me a pcap with the error? Can't reproduce using -bench=true, ACR/ACA looks ok here.

[fiorix]

Never mind, I can reproduce it.

[fiorix]

To get to the bottom of this one I instrumented the message and avp encoders with hex.Dump and noticed both were actually correct. However, when encoding messages we (re)use buffers from a sync.Pool, and those buffers were eventually dirty from previous usage. So the change is quite simple: reset padding bytes after serializing the avp. Ended up updating the serialization logic to be more straightforward, should be good now.

[fiorix]

Let me know if there's any more trouble.