Coder Social home page Coder Social logo

Comments (3)

kriswest avatar kriswest commented on September 17, 2024

Through the API fdc3.addEventListener returns a Listener object (as do addContextListener and addIntentListener). However, in the protocol we've given each listener its own message exchange for unsubscribe - but omitted one for the new event listeners.

I can go add a eventListenerUnsubscribeRequest and eventListenerUnsubscribeResponse - although a small voice is telling me we should perhaps be using a single exchange for all of these as they are all the same (payload is based on the listenerUUID).

@robmoffat @Roaders, any thoughts on that? Have a single message exchange for all instances of Listener.unsubscribe?

from fdc3.

Roaders avatar Roaders commented on September 17, 2024

From an implementation point of view it's probably going to be easier to have a separate message for each type of listener. Either that or have one message type but with a string union indicating what type of listener is being removed.

I think that I would prefer being able to tell which type of listener that I am removing rather than just relying on a listener ID and potentially needing an extra lookup to figure out what type it is.

Not too bothered though, either would be fine.

from fdc3.

kriswest avatar kriswest commented on September 17, 2024

This should do the job in that case: f9fddc1

If we want to unify these messages in future, I'm sure we could...

from fdc3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.