Comments (3)
Through the API fdc3.addEventListener
returns a Listener
object (as do addContextListener
and addIntentListener
). However, in the protocol we've given each listener its own message exchange for unsubscribe - but omitted one for the new event listeners.
I can go add a eventListenerUnsubscribeRequest
and eventListenerUnsubscribeResponse
- although a small voice is telling me we should perhaps be using a single exchange for all of these as they are all the same (payload is based on the listenerUUID
).
@robmoffat @Roaders, any thoughts on that? Have a single message exchange for all instances of Listener.unsubscribe
?
from fdc3.
From an implementation point of view it's probably going to be easier to have a separate message for each type of listener. Either that or have one message type but with a string union indicating what type of listener is being removed.
I think that I would prefer being able to tell which type of listener that I am removing rather than just relying on a listener ID and potentially needing an extra lookup to figure out what type it is.
Not too bothered though, either would be fine.
from fdc3.
This should do the job in that case: f9fddc1
If we want to unify these messages in future, I'm sure we could...
from fdc3.
Related Issues (20)
- Adding Event Listeners on Private Channel HOT 1
- Inconsistent Use of Promises HOT 6
- Bug or Inconsistency? HOT 1
- Question: AddContextListenerResponsePayload does not contain channelId HOT 2
- FDC3 monorepo HOT 2
- Use Cases and Workflows Discussion Group - 1st August 2024 HOT 5
- Make Listener.unsubscribe() async for consistency HOT 7
- Simplify Web Connection Protocol HOT 7
- IFramePositioning HOT 12
- RaiseIntentResultResponse HOT 5
- Question: resolvers / channel selectors UI HOT 5
- Spelling Error: FindIntentsByContextsResponse HOT 1
- broadcastEvent on no channel HOT 7
- Adding Channel State For JoinUserChannel / AddContextListener HOT 1
- Question: IntentEvent has no targetApp property HOT 3
- window.origin Requirement HOT 2
- Standard WG Meeting - August 22nd, 2024 HOT 8
- Add .NET docs for Events to API reference HOT 1
- GetAgentParams Not Optional HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fdc3.