Coder Social home page Coder Social logo

Comments (7)

FiniteSingularity avatar FiniteSingularity commented on September 28, 2024

Thank you for opening the issue. I can see how it would be a little confusing, however this is actually working as intended, as a pixel at size 1, is just the original pixel (so in terms of pixelization, 1 pixel is zero blur). We could allow the value to go to zero, as there is a check to see if the value is 1 or smaller, it just passes through the original frame. Is there any particular use case where having it go to zero is needed? Would it be less confusing to allow the slider to go to zero?

from obs-composite-blur.

JDDoesDev avatar JDDoesDev commented on September 28, 2024

I didn't have anyone in chat answering when I was attempting to use the transition, but in studio mode when enabling and disabling at 1.00 it seemed that there was a bit of a blurring, although minor. Let me see if I can find it in the VOD.

from obs-composite-blur.

FiniteSingularity avatar FiniteSingularity commented on September 28, 2024

Its definitely possible. It may have something to do with the float error that comes in, where a value of 1.0 is actually 1.0000001, which is greater than 1, so it isn't passing through the source. If that is the case, I can set an epsilon value to catch float rounding errors.

from obs-composite-blur.

JDDoesDev avatar JDDoesDev commented on September 28, 2024

https://www.twitch.tv/videos/1912841249 at 4:02:20 roughly.

There is some minor blurring, but after reviewing the VOD it is almost imperceptible. I'll let you take a look and decide if it's enough to put in a fix for, however I'm willing to close this as invalid after checking the VOD.

from obs-composite-blur.

FiniteSingularity avatar FiniteSingularity commented on September 28, 2024

I am going to close this one for now, as "works as expected." I am still considering allowing a "dummy" zero value for Pixelate and Dual Kawase, but that would come in the next feature release.

from obs-composite-blur.

FiniteSingularity avatar FiniteSingularity commented on September 28, 2024

@all-contributors please add @JDDoesDev for bug

from obs-composite-blur.

allcontributors avatar allcontributors commented on September 28, 2024

@FiniteSingularity

I've put up a pull request to add @JDDoesDev! 🎉

from obs-composite-blur.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.