perl didn't pass in enough information to figure out what went wrong about finance-quote

[jralls]

We've rewritten the F::Q interaction for GnuCash 5, which we'll release next spring, to collect and report a lot more error state from F::Q, including errormsg.

[bpschuck]

@jayenashar Not having used GnuCash 5.x myself yet, I believe this is now in place. So unless there is an objection, I will close this issue in the next few days.
Thank you.

[bpschuck]

Actually I misspoke earlier today, but I did find a bug in the code. The quote hash for each security can include an "errormsg" key value. Many of the methods don't populate it and the logic in Alphavantage.pm skips populating it when an "Information" key value pair is returned. The conversation I remember was a contributor wanting to be able to control printing the message to stdout or stderr based on a flag passed by environment variable or other means. A quick PoC gives me this.

use Finance::Quote;
my $q = Finance::Quote->new('alphavantage' => {API_KEY => 'demo'});
%quotes = $q->fetch("alphavantage", "F");
print "The price of Ford is " . $quotes{"F", "last"} . "\n";
if ( defined($quotes{"F","errormsg"}) ) {
  print "Errormsg: " . $quotes{"F","errormsg"} . "\n";
}

Running it returns:

The price of Ford is 
Errormsg: The **demo** API key is for demo purposes only. Please claim your free API key at (https://www.alphavantage.co/support/#api-key) to explore our full API offerings. It takes fewer than 20 seconds.

Change 'demo' in the code to a valid API Key and the price is valid but no error message is shown. Is this inline with what you are looking for?

[jayenashar]

sorry, i don't know. i'm just trying to improve the user experience of the average gnucash user. if you do print based on errormsg then you need @jrails or someone from gnucash to pick it up and present it to the user.

[bpschuck]

I'd have to ask, but I think they are aware of "errormsg" being a possible part of the quote hash passed back to GnuCash.

[bpschuck]

You may have seen my post to the gnucash-devel mailing list. Waiting for a response.

[jayenashar]

I didn't see it so thanks for letting me know.

[bpschuck]

No one responded to my list email. So I created a bugs.gnucash.org account and posted my email to https://bugs.gnucash.org/show_bug.cgi?id=798466.

[jayenashar]

thanks for your persistence