Comments (11)
We can do that in a next milestone.
from finch.
I have to test all the rubbish a did with types. It blows my mind.
from finch.
Hi @vkostyukov, I'm not sure if you've started this task yet, but if not, I have started writing some tests on a branch on my fork of finch. If you're ok with it, I can keep adding tests to this branch and PR when I'm done.
I wanted to make sure that you are fine with the testing library (scalatest) and spec style, which is the FlatSpec. If not let me know what your preference is and I'll use that.
I also would like to use scoverage to get a sense of code coverage and set up for #58. Does that sound good or do you prefer a different coverage tool?
Let me know what you think.
-- Ryan
from finch.
Hi Ryan @rpless,
This is great! Please go ahead with tests. I've looked through the couple of tests you wrote for RequiredParam
. Everything looks good. This is exactly what I was going to write.
Looking forward to accept a second contribution from you :)
Please also let me know in case of any issues/questions regarding the testing.
from finch.
@vkostyukov , so it turns out that scala's StringOps throws an IllegalArgumentException if a boolean cannot be parsed. This is not reflected in the scala 2.10.3 docs, but is reflected in the scala 2.11 docs.
This breaks the RequiredBooleanParam because toBoolean throws an IllegalArguementException and not a NumberFormatException when the RequiredBooleanParam calls StringToNumberOrFail. Do you want the fix to this as a separate PR or as part of the testing PR?
This question kinda of extends to the rest of the testing that I do. Should bugs that that are discovered be fixed on the test branch or in their own PR?
from finch.
@rpless, it's up to you. I think, It's not necessary to submit a separate pull-request for each bug. You can combine everything into a single PR within bunch of commits.
from finch.
Hi Ryan @rpless,
Just wanted to let you know, that I'm watching the changes in your test
branch :) Your tests as well as the fixes look great. Can't wait to merge them into Finch and ship new release 0.1.6.
from finch.
Hi Ryan @rpless,
How is it going with the tests. I see you've done a great work with writing test. Looks like everything is already tested in your test
branch. Do I miss something?
from finch.
Hi @vkostyukov, the response, request, and auth packages are mostly tested. I'm working through the json package right now. I haven't gotten to Endpoint or the main finch package. I've been using scoverage offline to track progress. There is approximately 65% test coverage. If you want to merge what I have now, I can push my remaining local changes and then make a PR.
from finch.
Hi @rpless, that's great! Let's merge the test you have now. I think it's not necessary to the JSON support, since I'm planing to replace it with some library. And I don't really know what to test in the Endpoint
class. Seems that Scala compiler tests it every time when compiles.
Please, go ahed and submit a PR with your work.
from finch.
Thanks a lot @rpless. I'm closing this issue, since the major part is tested now.
from finch.
Related Issues (20)
- Documentation mentions non-existing `io.finch.syntax._` HOT 4
- Hello World example from readme seems not to work HOT 2
- How to filter a group of endpoints but not others HOT 2
- Publish 0.32.1 to Sonatype/Maven Central HOT 4
- Document where the Encoder[Exception] error handler needs to be implicitly declared at HOT 1
- WebSocket support HOT 2
- Cats Effect 3 migration HOT 12
- Connection closed on error response while consuming FS2 streaming body
- Incompatible versions of jackson with other libraries HOT 4
- No content with 400 and 500 responses HOT 2
- Decoding Instant HOT 2
- Is finch dead? HOT 28
- Issues with Scala 2.13.7 HOT 15
- a native rust implementation of murmurhash3 HOT 1
- Add utility function to serve as a resource HOT 2
- Release schedule and `finchx-*` HOT 2
- Release 0.34.1 HOT 2
- Cannot use combineK to combine Endpoints HOT 3
- How do I upgrade .compile and .toService to finch 0.34? HOT 2
- Is support for Scala 3 planned? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from finch.