Add scala tests for the basic blocks about finch

[vkostyukov]

We can do that in a next milestone.

[vkostyukov]

I have to test all the rubbish a did with types. It blows my mind.

[rpless]

Hi @vkostyukov, I'm not sure if you've started this task yet, but if not, I have started writing some tests on a branch on my fork of finch. If you're ok with it, I can keep adding tests to this branch and PR when I'm done.

I wanted to make sure that you are fine with the testing library (scalatest) and spec style, which is the FlatSpec. If not let me know what your preference is and I'll use that.

I also would like to use scoverage to get a sense of code coverage and set up for #58. Does that sound good or do you prefer a different coverage tool?

Let me know what you think.

-- Ryan

[vkostyukov]

Hi Ryan @rpless,

This is great! Please go ahead with tests. I've looked through the couple of tests you wrote for RequiredParam. Everything looks good. This is exactly what I was going to write.

Looking forward to accept a second contribution from you :)

Please also let me know in case of any issues/questions regarding the testing.

[rpless]

@vkostyukov , so it turns out that scala's StringOps throws an IllegalArgumentException if a boolean cannot be parsed. This is not reflected in the scala 2.10.3 docs, but is reflected in the scala 2.11 docs.

This breaks the RequiredBooleanParam because toBoolean throws an IllegalArguementException and not a NumberFormatException when the RequiredBooleanParam calls StringToNumberOrFail. Do you want the fix to this as a separate PR or as part of the testing PR?

This question kinda of extends to the rest of the testing that I do. Should bugs that that are discovered be fixed on the test branch or in their own PR?

[vkostyukov]

@rpless, it's up to you. I think, It's not necessary to submit a separate pull-request for each bug. You can combine everything into a single PR within bunch of commits.

[vkostyukov]

Hi Ryan @rpless,

Just wanted to let you know, that I'm watching the changes in your test branch :) Your tests as well as the fixes look great. Can't wait to merge them into Finch and ship new release 0.1.6.

[vkostyukov]

Hi Ryan @rpless,

How is it going with the tests. I see you've done a great work with writing test. Looks like everything is already tested in your test branch. Do I miss something?

[rpless]

Hi @vkostyukov, the response, request, and auth packages are mostly tested. I'm working through the json package right now. I haven't gotten to Endpoint or the main finch package. I've been using scoverage offline to track progress. There is approximately 65% test coverage. If you want to merge what I have now, I can push my remaining local changes and then make a PR.

[vkostyukov]

Hi @rpless, that's great! Let's merge the test you have now. I think it's not necessary to the JSON support, since I'm planing to replace it with some library. And I don't really know what to test in the Endpoint class. Seems that Scala compiler tests it every time when compiles.

Please, go ahed and submit a PR with your work.

[vkostyukov]

Thanks a lot @rpless. I'm closing this issue, since the major part is tested now.